add deployment workflows for GitHub Pages #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5 tasks
colebemis
approved these changes
Apr 19, 2022
jonrohan
reviewed
Apr 19, 2022
| outputs: | ||
| # To avoid deploying documentation for unrelease changes, we check the number of changeset files. | ||
| # If it's 0, we deploy. | ||
| should_deploy: ${{ steps.changeset-count.outputs.change_count == 0 }} |
There was a problem hiding this comment.
Interesting I've never seen these guard options
jonrohan
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What are you trying to accomplish?
Part of github/primer#886
Replaces deployment target for all docs from Vercel to GitHub Pages
What approach did you choose and why?
Utilises reusable workflows make future deployments consistent with other Primer repo's.
What should reviewers focus on?
Use the new preview urls, which will appear in all new PRs - including this one - as follows:
or
Review the latest preview deployment and check everything is appearing correctly🙏
Can these changes ship as is?
Todo
Post-merge