Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspending inside a hidden tree should not cause fallbacks to appear #24699

Merged
merged 2 commits into from Jul 5, 2022

Conversation

acdlite
Copy link
Member

@acdlite acdlite commented Jun 9, 2022

If something suspends inside a hidden tree, it should not affect anything in the visible part of the UI. This means that Offscreen acts like a Suspense boundary whenever it's in its hidden state.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team labels Jun 9, 2022
@sizebot
Copy link

@sizebot sizebot commented Jun 9, 2022

Comparing: c1f5884...27f8b68

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.01% 131.79 kB 131.80 kB +0.01% 42.40 kB 42.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.01% 137.06 kB 137.07 kB +0.01% 44.00 kB 44.00 kB
facebook-www/ReactDOM-prod.classic.js +0.02% 457.38 kB 457.49 kB +0.03% 83.24 kB 83.26 kB
facebook-www/ReactDOM-prod.modern.js +0.02% 442.62 kB 442.73 kB +0.03% 80.96 kB 80.98 kB
facebook-www/ReactDOMForked-prod.classic.js +0.94% 458.15 kB 462.44 kB +0.72% 83.35 kB 83.94 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMForked-prod.modern.js +0.97% 443.40 kB 447.68 kB +0.80% 81.07 kB 81.72 kB
facebook-www/ReactDOMForked-profiling.modern.js +0.96% 473.55 kB 478.12 kB +0.85% 85.60 kB 86.33 kB
facebook-www/ReactDOMForked-profiling.classic.js +0.94% 488.38 kB 492.95 kB +0.77% 87.96 kB 88.64 kB
facebook-www/ReactDOMForked-prod.classic.js +0.94% 458.15 kB 462.44 kB +0.72% 83.35 kB 83.94 kB
facebook-www/ReactDOMForked-dev.modern.js +0.59% 1,162.06 kB 1,168.95 kB +0.47% 256.35 kB 257.55 kB
facebook-www/ReactDOMForked-dev.classic.js +0.58% 1,185.68 kB 1,192.57 kB +0.45% 260.85 kB 262.03 kB

Generated by 🚫 dangerJS against 27f8b68

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Reviewed together offline, lgtm

@acdlite acdlite force-pushed the offscreen-suspense branch 5 times, most recently from 153f3d8 to 6e7e26b Compare Jul 5, 2022
acdlite added 2 commits Jul 5, 2022
If something suspends inside a hidden tree, it should not affect
anything in the visible part of the UI. This means that Offscreen acts
like a Suspense boundary whenever it's in its hidden state.
@acdlite acdlite merged commit 82e9e99 into facebook:main Jul 5, 2022
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants