Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide from v1 to v2? #787

Open
rhansen opened this issue Nov 22, 2021 · 2 comments
Open

Migration guide from v1 to v2? #787

rhansen opened this issue Nov 22, 2021 · 2 comments
Labels
good first issue Priority: Low Status: Accepted Type: Documentation

Comments

@rhansen
Copy link

@rhansen rhansen commented Nov 22, 2021

Support plan

  • which support plan is this issue covered by? (e.g. Community, Sponsor, or
    Enterprise): Community
  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: v16.13.0
  • module (formidable) version: v1.2.6
  • environment (e.g. node, browser, native, OS): node
  • used with (i.e. popular names of modules):
  • any other relevant information:

What problem are you trying to solve?

What changes are needed to migrate from v1.2.6 to v2.0.1? CHANGELOG.md is not very readable, and VERSION_NOTES.md doesn't mention any compatibility-breaking changes other than Node.js 10+. Can we simply upgrade to v2.0.1 and expect everything to work without any changes?

Do you have a new or modified API suggestion to solve the problem?

@GrosSacASac
Copy link
Contributor

@GrosSacASac GrosSacASac commented Nov 22, 2021

PR welcome :)

It depends on what features you used. The interface of certain objects has changed.

@tunnckoCore
Copy link
Member

@tunnckoCore tunnckoCore commented Nov 22, 2021

Can we simply upgrade to v2.0.1 and expect everything to work without any changes?

Almost, yes. I think it's just the resulted "File" object propeties. See #773 for the different names of props.

I can add a diff codeblock in the v2 part of the version notes, based on that 773.

@tunnckoCore tunnckoCore added good first issue Priority: Low Status: Accepted Type: Documentation and removed docs labels Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Priority: Low Status: Accepted Type: Documentation
Projects
None yet
Development

No branches or pull requests

3 participants