Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Terminals #379

Open
Angelk90 opened this issue Apr 2, 2022 · 3 comments
Open

Multiple Terminals #379

Angelk90 opened this issue Apr 2, 2022 · 3 comments
Labels
enhancement good first issue
Projects

Comments

@Angelk90
Copy link
Contributor

@Angelk90 Angelk90 commented Apr 2, 2022

Describe the solution you'd like

As you can see from the image, being able to have more than one shell in a project would be great.

Edit by @austincondiff:

This is the design that we will use for multiple terminals. We need this tab system in place in the status bar and the git controls moved up to the toolbar first, then in the terminal tab build the multiple terminal tabs UI, this is how this would look.

01-macOS-code-edit-alternate-ui-drawer-tabs-terminal

Please note the following behaviors:

  • The plus icon adds a new terminal tab (not in a group).
  • The minus button closes the selected tab.
  • Press the delete key while terminal tab sidebar is in focus to close the selected tab.
  • Drag an ungrouped terminal tab on top of another ungrouped terminal tab to create a group.
  • Drag an ungrouped terminal tab into an existing group to add it to that group.
  • Drag a terminal tab within a group to reorder it.
  • Drag a grouped terminal tab to another group to move it to another group.

Describe alternatives you've considered

Here are some examples of how it handles Webstorm:

Schermata 2022-04-02 alle 09 40 31

Schermata 2022-04-02 alle 09 41 17

Schermata 2022-04-02 alle 09 42 11

Screen.Recording.2022-03-24.at.5.21.16.PM.mp4

Additional context

Schermata 2022-04-02 alle 09 37 02

Depends on

@Angelk90 Angelk90 added the enhancement label Apr 2, 2022
@austincondiff austincondiff changed the title Multi shell Multiple Terminals Apr 2, 2022
@Angelk90
Copy link
Contributor Author

@Angelk90 Angelk90 commented Apr 2, 2022

@austincondiff : What program is that in the video?

Opening would be better like this:

Registrazione.schermo.2022-04-02.alle.12.58.58.mov

@nanashili nanashili added the good first issue label Apr 2, 2022
@austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Apr 3, 2022

@Angelk90 I agree that it should open as a drawer like in your video. That video is from VSCode, and demonstrates how it handles terminal tabs and split terminal views. The question we need to answer for this is how are we going to do multiple terminals in this drawer? Will we use tabs? How will we handle split terminals? Will terminals be the only thing that exists in this drawer or will there be other kinds of things like output, issues, debug, console, etc.?

@austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Apr 12, 2022

This is the design that we will use for multiple terminals. We need this tab system in place in the status bar and the git controls moved up to the toolbar first, then in the terminal tab build the multiple terminal tabs UI, this is how this would look.

01-macOS-code-edit-alternate-ui-drawer-tabs-terminal

Please note the following behaviors:

  • The plus icon adds a new terminal tab (not in a group).
  • The minus button closes the selected tab.
  • Press the delete key while terminal tab sidebar is in focus to close the selected tab.
  • Drag an ungrouped terminal tab on top of another ungrouped terminal tab to create a group.
  • Drag an ungrouped terminal tab into an existing group to add it to that group.
  • Drag a terminal tab within a group to reorder it.
  • Drag a grouped terminal tab to another group to move it to another group.

(updated in issue description)

@stale stale bot added wontfix and removed wontfix labels Jun 11, 2022
@CodeEditApp CodeEditApp deleted a comment from stale bot Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue
Projects
Release 1.0
Features To do
Development

No branches or pull requests

3 participants