[RFC] af_rubberband: add new engine option for rubberband 3.0.0 #10420
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of bumping the library version, you could do a version check in the build systems and enable the new engine option if the version is new enough. Like how JPEGXL detection works. |
christoph-heinrich
force-pushed
the
rubberband_3
branch
from
fcc5384
to
fe56480
Compare
|
It's now in line with JPEGXL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Rubber Band Library version 3.0.0 has been released with a new processing engine and accompanying option
OptionEngineFiner. WithOptionEngineFasterthe old engine is used.So far the minimum version for rubberband was 1.8.0.
This probably can't be merged for a while, because not even Arch has updated to the new rubberband yet.
I don't know how CI has to be changed for this.
Hasn't been tested.
Closes #10417