Run on FloydHub integration #961
Conversation
Thanks! This looks good, just 2 small nits, could you correct them?
README.md
Outdated
| @@ -34,15 +35,21 @@ installs T2T, downloads MNIST, trains a model and evaluates it: | |||
| ``` | |||
| pip install tensor2tensor && t2t-trainer \ | |||
| --generate_data \ | |||
| --data_dir=~/t2t_data \ | |||
| --output_dir=~/t2t_train/mnist \ | |||
| --data_dir=./t2t_data \ | |||
There was a problem hiding this comment.
Let's not change the home directory here, it's really better to make this in ~.
README.md
Outdated
| --problem=image_mnist \ | ||
| --model=shake_shake \ | ||
| --hparams_set=shake_shake_quick \ | ||
| --train_steps=1000 \ | ||
| --eval_steps=100 | ||
| ``` | ||
|
|
||
| ### Run on FloydHub |
There was a problem hiding this comment.
Could you move this section to the end, before papers? Thanks!
There was a problem hiding this comment.
And also add a line to the TOC.
And could you flesh out how to actually use FloydHub with T2T? I clicked the button and have a workspace but it's not clear how I would run t2t-trainer or otherwise use T2T.
README.md
Outdated
| @@ -9,6 +9,7 @@ welcome](https://img.shields.io/badge/contributions-welcome-brightgreen.svg)](CO | |||
| [](https://gitter.im/tensor2tensor/Lobby) | |||
| [](https://opensource.org/licenses/Apache-2.0) | |||
| [](https://travis-ci.org/tensorflow/tensor2tensor) | |||
| [](https://floydhub.com/run?template=https://github.com/tensorflow/tensor2tensor) | |||
There was a problem hiding this comment.
Let's follow the Basic Setup and rm the template parameter.
https://docs.floydhub.com/guides/run_on_floydhub_button/#basic-setup
README.md
Outdated
| --problem=image_mnist \ | ||
| --model=shake_shake \ | ||
| --hparams_set=shake_shake_quick \ | ||
| --train_steps=1000 \ | ||
| --eval_steps=100 | ||
| ``` | ||
|
|
||
| ### Run on FloydHub |
There was a problem hiding this comment.
And also add a line to the TOC.
And could you flesh out how to actually use FloydHub with T2T? I clicked the button and have a workspace but it's not clear how I would run t2t-trainer or otherwise use T2T.
| @@ -0,0 +1 @@ | |||
| env: tensorflow-1.9 | |||
|
@lukaszkaiser @rsepassi thanks for the feedback! I have just updated the PR. |
PiperOrigin-RevId: 207941265
Hi @lukaszkaiser , here's the Run on FloydHub integration.
README.mdfloyd.ymlconfig file to specify the environmentfloyd_requirements.txtfile to automatically install tensor2tensor in the environmentI've changed the data and checkpoint paths of the examples in the
README.mdfrom~/(HOME mapping) to./(current working directory) to improve usability. Sounds good for you?Looking forward to your feedback :)