#22418 Page Manager (first attempt) - Create Favorite Page #22424
Conversation
jdotcms
commented
Jun 16, 2022
•
- Adding permissions to the workflow
- Creating favorite page contentlet functionality
… into issue-22418-wfapi-permission
… into issue-22418-wfapi-permission
… into issue-22418-wfapi-permission
alfredo-dotcms
force-pushed
the
issue-22418-wfapi-permission
branch
from
bea8c96
to
cc3f200
Compare
|
alfredo-dotcms
force-pushed
the
issue-22418-wfapi-permission
branch
from
82137ca
to
d7f940e
Compare
.../app/portlets/dot-edit-page/components/dot-favorite-page/dot-favorite-page.component.spec.ts
Show resolved
Hide resolved
| form: FormGroup; | ||
| isFormValid$: Observable<boolean>; | ||
| pageRenderedHtml: string; |
| loading: boolean; | ||
| closeDialog: boolean; | ||
| } | ||
|
|
||
| export const enum LoadingState { | ||
| INIT = 'INIT', | ||
| LOADING = 'LOADING', | ||
| LOADED = 'LOADED' | ||
| } |
There was a problem hiding this comment.
We should unify LoadingState and loading being a boolean, makes no sense to have two, check this post: https://indepth.dev/posts/1033/ngrx-how-and-where-to-handle-loading-and-error-states-of-ajax-calls
| // This is needed to wait until the Web Component is rendered | ||
| setTimeout(() => { | ||
| const dotHtmlToImageElement = document.querySelector('dot-html-to-image'); | ||
| dotHtmlToImageElement.addEventListener('pageThumbnail', (event: CustomEvent) => { |
| }, '*') | ||
| }); | ||
| }).catch(function (error) { | ||
| console.error('oops, something went wrong!', error); |
There was a problem hiding this comment.
Shouldn't we show a popup? So the user can see the message. We can also use an alert.
| forkJoin([this.dotRolesService.search(), this.dotCurrentUser.getCurrentUser()]) | ||
| .pipe(take(1)) | ||
| .subscribe(([roles, currentUser]: [DotRole[], DotCurrentUser]): void => { | ||
| console.log(roles, currentUser); |
| pageState: DotPageRenderState; | ||
| } | ||
|
|
||
| export interface DotFavoritePageFormData { |
There was a problem hiding this comment.
move these interfaces to other file ?
There was a problem hiding this comment.
this is only used on this component due to its props and form
There was a problem hiding this comment.
Then export is not need it.
it's also used on the STORE (that's why the export), still don't think it's needed to be put on a separate file
There was a problem hiding this comment.
@oidacra and I are working in a structure for this... will be out soon.
| } | ||
| }); | ||
|
|
||
| // This is needed to wait until the Web Component is rendered |
There was a problem hiding this comment.
ca we use ngAfterViewInit ?
| @@ -5,6 +5,11 @@ | |||
| [url]="pageState.page.pageURI" | |||
| [apiLink]="apiLink" | |||
| ></dot-edit-page-info> | |||
| <!-- <dot-icon-button | |||
There was a problem hiding this comment.
this is hidden while it gets ready for release
| forkJoin([this.dotRolesService.search(), this.dotCurrentUser.getCurrentUser()]) | ||
| .pipe(take(1)) | ||
| .subscribe(([roles, currentUser]: [DotRole[], DotCurrentUser]): void => { | ||
| console.log(roles, currentUser); |
| }); | ||
|
|
||
| // This is needed to wait until the Web Component is rendered | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Maybe we can use requestAnimationFrame instead of setTimeout. doc
| }, '*') | ||
| }); | ||
| }).catch(function (error) { | ||
| console.error('oops, something went wrong!', error); |
There was a problem hiding this comment.
Shouldn't we show a popup? So the user can see the message. We can also use an alert.
alfredo-dotcms
force-pushed
the
issue-22418-wfapi-permission
branch
from
4730bca
to
93d651e
Compare
| pageState: DotPageRenderState; | ||
| } | ||
|
|
||
| export interface DotFavoritePageFormData { |
| isAdmin: props.pageState.user.admin, | ||
| imgWidth: parseInt(props.pageState.params.viewAs.device?.cssWidth, 10) || 1024, | ||
| imgHeight: | ||
| parseInt(props.pageState.params.viewAs.device?.cssHeight, 10) || | ||
| (parseInt(props.pageState.params.viewAs.device?.cssWidth, 10) || 1024) / | ||
| IMG_RATIO_43 | ||
| }; |
There was a problem hiding this comment.
Still think that is an overhead send the pageState to use 3 props.
...src/app/portlets/dot-edit-page/components/dot-favorite-page/store/dot-favorite-page.store.ts
Show resolved
Hide resolved
| <dot-icon-button | ||
| data-testId="addFavoritePageButton" | ||
| icon="star_outline" | ||
| (click)="addFavoritePage()" | ||
| ></dot-icon-button> |
There was a problem hiding this comment.
We need to hide this at this point no?
|
|
||
| doc.body.append(scriptLib); | ||
|
|
||
| window.addEventListener('message', (event) => { |
There was a problem hiding this comment.
Take a look at this video: https://youtu.be/YDU_3WdfkxA?t=681
I think this code will result in the same issue.
alfredo-dotcms
force-pushed
the
issue-22418-wfapi-permission
branch
from
5e959ca
to
94b06c7
Compare
