arduino / arduino-cli Public

)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 3 to 4.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v3...v4)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…1692)

Validation of links to internal anchors was recently added to the markdown-link-check tool used to check for broken
links in this project's documentation.

Although a much needed feature, unfortunately it does not currently support anchors created by HTML anchor tags.

For example, this is valid and common Markdown:

[click here](#some-anchor)
<a name="some-anchor"></a>

but will fail the check:

ERROR: 1 dead links found!
[x] #some-anchor -> Status: 404

This type of link markup is used by the protoc-gen-doc tool that generates the gRPC interface documentation, which
causes a spurious failure of the link check.

The solution is to configure markdown-link-check to skip these links (which was the behavior anyway with versions 3.8.7
and older). That will be reverted whenever the tool is able to correctly validate internal anchor links.

* bump go version we use to build and release to go 1.17.8

Co-authored-by: per1234 <[email protected]>

* bump go version in go.mod

* bump go version in GH Actions workflows

* bump go version in the docs

Co-authored-by: per1234 <[email protected]>

…1688)

* update documentation links

* Update docs/library-specification.md

Co-authored-by: per1234 <[email protected]>

Co-authored-by: per1234 <[email protected]>

#1680)

* Make use of 'avr' as example platform more consistent

It's fairly easy to miss the one line early in the doc that says this text uses 'avr' as an example, leading a reader to possibly believe the documentation hasn't been updated since 'avr' was the only platform choice. Within the doc, the text was a little inconsistent as to how it referred to the avr platform and platform specific tools. This change tries to standardize how we refer to the example platform.

* Fix a couple lint errors.

* Fix prettier lint errors.

* Fix an additional prettier lint error

* Update docs/sketch-build-process.md

Co-authored-by: per1234 <[email protected]>

Co-authored-by: per1234 <[email protected]>

…API (#1682)

* Removed `error` return from `discovery.New(...)`

The `New` function never fails.

* Replaced *status.Status with errors in packagamanager

* Apply suggestions from code review

Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 3.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…rd (#1673)

* Discoveries are now closed and unregistered after failure

* Add mutex to guard discoveries in DiscoveryManager

* Fixed all lint warnings

* Replaced findFilesInFolder with go-paths equivalent

* Removed some constants

* Removed unused parameter

* Removed redundant builder_utils.CompileFilesRecursive function

* Simplified structure of CompileFiles

* Inlined call to compileFilesWithRecipe

* Removed unused function FindAllSubdirectories

* Rewrite of FindFilesInFolder using go-paths-helper

* Updated dependency go.sum and licensed cache

* Removed duplication of extensions table

* Applied suggestion from codereview

* Update legacy/builder/builder_utils/utils.go

Co-authored-by: Silvano Cerza <[email protected]>

* Applied code review suggestions

* Applied code review suggestions

Co-authored-by: Silvano Cerza <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…sers (#1647)

* Sample command to solve compile or upload issue is now shown to CLI users

* Fix error strings

Co-authored-by: per1234 <[email protected]>

* Enhance error message if core is unknown

* Fix compile error not being printed if output is json

Co-authored-by: per1234 <[email protected]>

…1648)

* Added deprecation warning for gRPC MonitorService

* Apply suggestions from code review

Co-authored-by: per1234 <[email protected]>

* Added deprecation option

Co-authored-by: per1234 <[email protected]>

* Remove some constants indirection

* Added support for advanced-sizers

* Added documentation

* Apply suggestions from code review

Co-authored-by: Silvano Cerza <[email protected]>

* Update docs/platform-specification.md

Co-authored-by: Silvano Cerza <[email protected]>

* Enforce severity correctness from sizer tool

* Apply suggestions from code review

Co-authored-by: per1234 <[email protected]>

* Use 'max_size' field name in json to match cli output

* Apply suggestions from code review

Co-authored-by: per1234 <[email protected]>

Co-authored-by: Silvano Cerza <[email protected]>
Co-authored-by: per1234 <[email protected]>

… gRPC client version (#1640)

* Fix lint warning

* Add support for global env variable set over arduino-cli

* PackageManager now has a user-agent

* Propagate 'user-agent' info to tools via environment vars

* Allow nil PackageManager in GetEnvVarsForSpawnedProcess()

* Added docs

* Apply suggestions from code review

Co-authored-by: per1234 <[email protected]>

* Added docs for breaking change in golang API

* Fixed behaviour of Process.SetEnvironment

* Simplified some appends

Co-authored-by: per1234 <[email protected]>

…ome rare conditions (#1638)

* Improve error logging for pluggable monitor

* Force quit of pluggable monitor if the port open fails

)

* Add organization env var in i18n transifex script

* Update i18n transifex push command to use API v3

* Update i18n transifex pull command to use API v3

* Remove duplicated code

* Add success message after successfull resource upload

* Reworked i18n scripts to unmarshal data to structs

* Fixed wrong defer

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…rm (#1637)

* bugfix: monitorDependencies are now installed with the core

* added test

…ry/montior (#1636)

* Fixed wrong "event" fields in pluggable monitor specs

* Better specify discoveryDependencies and monitorDependencies fields in package_index.json

…s and monitors (#1633)

* Allow case-insensitive 'ok'/'OK' replies from discoveries and monitors

* Factor the same messages to reduce translations strings

* Better error messages for discoveries and monitor

…it (#1629)

* Factored property composition in convertUploadToolsToPluggableDiscovery

* Auto-generated properties are cached and added after cycling on the original map

* Autogenerated upload tool properties are searched in sub-configs too

Fix #1444

* Added STMicroelectronics:stm32:Nucleo_32:pnum=NUCLEO_F031K6 to upload mock tests

* Use composed board properties to detect user fields

Some platforms may add information through the optional config part of
the FQBN (platforms menu items).

* legacy: refactored ErrorfWithLogger function

Now is no longer needed, this function was basically made for
arduino-builder to allow transfering the error to the IDE, BTW the
correct fix must be made inside arduino-builder (to actually let him
push the error in the logger).

* Renamed legacy ctx fields ExecStdout/ExecStderr to Stdout/Stderr

* Removed empty Lint() function

* Removed dependency on i18n.Logger

* Removed no more used i18n.Logger \o/ \o/

* Simplified i18n.Init function

* legacy: builder default output on os.Stdout/os.Stderr

* legacy: updated integration tests for slightly different output of builder

* Use positional parameter for most translated string

This will make easier to transfer translations from the Arduino IDE 1.8

* Added note to UPGRADING.md

* Updated UPGRADING.md

* Removed extra blank line in library detection recap

* Update docs/UPGRADING.md

Co-authored-by: per1234 <[email protected]>

Previously we checked the recipe for the {serial.port} key to determine
if the upload requires a serial port, but this is not sufficient because
we must check also for the {serial.port.file} key.