Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added override keyword to codefix implemented abstract methods #51033

Merged

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 2, 2022

Passes an overridesAbstract flag down the codefix methods so the member adder knows whether to add an override keyword.

Fixes #50464

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Oct 2, 2022
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review Oct 2, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the title Added override keyword to codefixed implemented abstract methods Added override keyword to codefixe implemented abstract methods Oct 3, 2022
@sandersn sandersn added this to Not started in PR Backlog Oct 18, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the title Added override keyword to codefixe implemented abstract methods Added override keyword to codefix implemented abstract methods Oct 19, 2022
@sandersn sandersn moved this from Not started to Waiting on reviewers in PR Backlog Dec 9, 2022
src/services/codefixes/helpers.ts Outdated Show resolved Hide resolved
src/services/completions.ts Outdated Show resolved Hide resolved
src/services/codefixes/helpers.ts Outdated Show resolved Hide resolved
PR Backlog automation moved this from Waiting on reviewers to Waiting on author Dec 11, 2022
@JoshuaKGoldberg JoshuaKGoldberg requested review from gabritto and removed request for RyanCavanaugh Dec 16, 2022
@gabritto
Copy link
Member

gabritto commented Dec 16, 2022

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 16, 2022

Heya @gabritto, I've started to run the tarball bundle task on this PR at 67a940b. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 16, 2022

Hey @gabritto, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/140709/artifacts?artifactName=tgz&fileId=601E553E870D8ECFEE2E4396F3B1F5B78C486F3F224491B99652B10E7D60792E02&fileName=/typescript-5.0.0-insiders.20221216.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-51033-2".;

Copy link
Member

@gabritto gabritto left a comment

Thanks!

PR Backlog automation moved this from Waiting on author to Needs merge Dec 16, 2022
@gabritto gabritto merged commit 2484390 into microsoft:main Dec 16, 2022
17 checks passed
PR Backlog automation moved this from Needs merge to Done Dec 16, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the codefix-implement-abstract-override branch Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

Quick fix: "Implement inherited abstract class" should add override keyword to methods
3 participants