leighmcculloch
Follow
Pinned
4,900 contributions in the last year
Less
More
Activity overview
Contributed to
stellar/rs-soroban-sdk,
stellar/rs-soroban-env,
stellar/soroban-cli
and 152 other
repositories
Contribution activity
October 2022
Created 169 commits in 14 repositories
Created a pull request in stellar/soroban-docs that received 27 comments
Next Release Dev Branch
What
Changes for the next release.
Why
For tracking the dev branch.
Deployed to https://soroban-dev.stellar.org.
cc @tyvdh @stellar/contract-commit…
+3,045
−848
•
27
comments
Opened 144 other pull requests in 13 repositories
stellar/soroban-docs
51
merged
- Make it clearer that optimization is unnecessary
- Fixes to examples and docs
- Add multisig wallet example
- Update soroban-cli to v0.1.2
- Fix broken links
- Update soroban-cli version
- Update byo sdk page
- Move the optimized build instructions inside the build page to shorten the list of tutorials
- Update the links for reporting issues
- Add details about building with logs to project setup
- Remove out-dated recommendation about testutils feature
- Move timelock example to be higher up in the example list
- Update versions of sdks and tools
- Add vscode links
- Remove token example from docs
- Move the FAQ to the top level
- Add short page about time lock example
- Update advanced auth example
- Add run in pages
- Update the auth example to use the increment based auth example
- Update the custom types example
- Add footprint example to an example
- Move tip into correct location in events example
- Compact the error example to match other examples
- Update events example
- Some pull requests not shown.
stellar/soroban-examples
26
merged
1
open
- Open readme and files on boot in gitpod
- Fix link in README
- Run a futurenet node in gitpod env
- Add a default file to open on load of gitpod
- Add gitpod config
- Remove macro_use and extern crate uses that are unnecessary
- Fix var name
- Change advanced-auth example to be built on increment example
- Rewrite the auth example to be based on the increment example
- Rewrite the custom types example to use increment example
- Change the events contract to be an adaption of the increment example
- Add logs to increment example
- Shorten the errors tests
- Add errors example
- Update soroban-sdk, etc
- Update soroban-*
- Remove unnecessarily hardcoded contract IDs
- Update soroban-sdk
- Output logs to stdout when running tests in logging example
- Rename id to addr in auth contract
- Update soroban-sdk
- Add logging example
- Add comments to deployer example
- Rename admin fn in auth example.
- Rename auth example
- Some pull requests not shown.
stellar/soroban-cli
21
merged
1
closed
- Support Linux aarch64 builds
- Publish binaries
- Retroactively add binaries to the release of v0.1.2
- Move the git revision logic to a crate
- Check container is ready in e2e-test ci job
- Group test-wasms in fixtures and use for e2e test
- Create source account
- Update deps and get BytesM/StringM
- Fix the url the invoke client connects to for the rpc
- Embed the token spec
- Update soroban-spec, soroban-env, stellar-strkey, etc
- Group sandbox and rpc options together
- Reorder options in commands
- Add back ability to use --wasm in remote invoke
- Output the ledger footprint when invoking
- Remove some unused deps
- Add git sha to version information
- Rename private-strkey to secret-key
- Update soroban-spec
- Change footprint in serve responses to use xdr
- Rename soroban-cli to soroban
- Update soroban-spec, soroban-env, stellar-xdr
stellar/rs-soroban-sdk
17
merged
1
closed
- Fix soroban-auth testutils docs
- Add example passing signer to helper fns
- Use a single target dir for builds
- Fix token spec spec_xdr fn
- Remove superfluous feature cfg
- Remove deprecated functions
- Update stellar-xdr, soroban-env and get BytesM/StringM
- Update main example in Rust docs to use auto generated contract id
- Add Logger::print in testutils
- Fix bug in contracterror
- Update soroban-env, stellar-xdr
- Reorder Env functions for better docs presentation
- Make contract_id optional in contract registrations
- Rename Invoker -> Address
- Remove unused types from token interface
- Provide a succinct way to invoke as a source account in tests
- Use refs for AccountIds in Env interface
- Add AccountId <> Identifier conversions
stellar/rs-soroban-env
2
closed
5
merged
stellar/actions
6
merged
1
closed
stellar/wasmi
4
merged
leighmcculloch/cargo-set-rust-version
2
merged
stellar/rs-stellar-xdr
2
merged
stellar/stellar-xdr-next
1
open
stellar/crate-git-revision
1
merged
stellar-deprecated/soroban-token-contract
1
merged
stellar/xdrgen
1
merged
Reviewed 85 pull requests in 16 repositories
stellar/soroban-example-dapp
21 pull requests
- Update README.md
- feat: add binaryen to package.json to get local wasm-opt binary
- chore: cargo clippy --fix
- fix: use tiny wasm when deploying crowdfund contract
- Update to soroban-client 0.1.1
- Update to use soroban-client package
- Enable futurenet
- Working against standalone
- Change contract 'owner' to 'recipient', to clarify their role
- Add Freighter support
- Add a screenshot to the readme
- Quickstart
- Added "Approve transfer" to button text
- Deploy crowdfund to a random contract ID to be more realistic.
- [WIP] quickstart support
- Only avoid throwing 404 errors
- Simplify and remove mint.sh. It doesn't work right anyway
- Get deposit workflow working
- Hack to get simulateTransaction token.approve working
- Update the simulateTransaction footprint format
- Use new soroban-cli token create subcommand
stellar/soroban-cli
20 pull requests
- Add token contract e2e test
- Check container is ready in e2e-test ci job
- Create source account
- Add first integration test
- Update deps and get BytesM/StringM
- Change cli serve defaults and path to match quickstart docker
- invoke: Fix (and enforce) getContractData invocation
- Inspect and use the error from simulateTransaction
- Make sandbox deploy contract id optional
- Add contractCode to token init footprint
-
Swap std:
🧵 :sleep for tokio::time::sleep - Add env vars for network config flags
- invoke: Print result when using an RPC Server
- Fix binary name in instructions in README
- Don't print rpc status to stdout
- Invoke contract from RPC server
- Allow user to specify custom salt when deploying to remote rpc server
- Update the sdk to 864a309b
- Improve serve's txn processing error messages
- Fix sequence number in deploy's transaction
stellar/rs-soroban-env
12 pull requests
- Synth wasm
- Pseudo random
- Correct / tidy up / comment calibration code.
- Add token events
- Added more test coverage for built-in token.
- Vm tuning
-
Respect trustline limit in
to_classicconversions - Forbid contract reentry
- Always return Account if there's only one frame
- Use import and export instead of to_smart and to_classic
- Cleanup, consolidate metering for read/write_xdr
- Remove wrap
stellar/soroban-docs
9 pull requests
stellar/soroban-examples
5 pull requests
stellar/rs-soroban-sdk
3 pull requests
stellar/actions
2 pull requests
stellar/stellar-core
2 pull requests
stellar/rs-stellar-strkey
2 pull requests
stellar/quickstart
2 pull requests
stellar/java-stellar-anchor-sdk
2 pull requests
stellar/stellar-protocol
1 pull request
stellar/js-soroban-client
1 pull request
stellar/go
1 pull request
stellar/stellar-xdr-next
1 pull request
stellar/starbridge
1 pull request
Created an issue in stellar/rs-soroban-env that received 17 comments
Automate import/export in the token contract
The manual import/export in the token contract encourages choice for the user about where they want to keep funds, which raises inconvenient decisi…
17
comments
Opened 43 other issues in 14 repositories
stellar/rs-soroban-sdk
10
open
2
closed
- Add separate functions for mutating single fields of the ledger info
- Auth account signature test utilities
- Soroban-auth testutils don't render in docs.rs
- Make a way to be a contract in tests
- Test utilities for creating trust lines, assets, issuance, etc for accounts
- Embed SDK and Auth SDK version into build contracts
- Experiment with methods to automatically include debug event logs in tests using the SDK
- Setup an example in an online IDE such as repl.it or gitpod
- Add support for getting contract IDs that would be assigned to deployments
- Support contractimport! with a network and a contract identifier
- Offer built-in contracts via contractimport
- Consider consolidating Account and Contract into an Address in soroban_auth::Identifier
stellar/soroban-cli
7
open
1
closed
- Add builds for all platforms to publish dry run (Linux aarch64, macOS x64/aarch64, and Windows)
- Support releases for Windows
- Support releases on Linux aarch64
- Add ability to invoke as a read-only simulate transaction only
- Store CLI version in ledger JSON file and error if it is different to current
- CLI: Don't sign preflight transactions
- CLI: Redesign
- CLI: Update clap-rs to v4
stellar/soroban-docs
1
open
5
closed
stellar/rs-soroban-env
5
open
- Add a function to the token contract to get the admin
- Add host functions that calculate contract IDs from inputs
- Add Asset as a first-class ScObject
- A contract invocation that fails with a trap or error results in a successful operation / transaction result
- Token contract is easy to misuse because of similar function params
stellar/actions
3
open
gitpod-io/gitpod
1
open
rust-lang/rust-clippy
1
open
taiki-e/upload-rust-binary-action
1
closed
stellar/soroban-example-dapp
1
open
stellar/soroban-examples
1
open
excalidraw/excalidraw
1
open
stellar/stellar-core
1
closed
rust-lang/cargo
1
open
Started 1 discussion in 1 repository
clap-rs/clap
clap-rs/clap
-
How to define a repeating option that accepts multiple formats?
This contribution was made on Oct 15
20
contributions
in private repositories
Oct 3 – Oct 24