Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBF: remove ddt from requirements.txt since no ddt required at run time. #911
Conversation
Otherwise, since requirements.txt is loaded into install_requires, any installation which manages to miss installing ddt could cause setuptools to freak out. E.g. here is a traceback from running tests of datalad ====================================================================== ERROR: datalad.metadata.tests.test_aggregation.test_update_strategy ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/datalad/metadata/metadata.py", line 511, in _get_metadata extractor_cls = extractors[mtype_key].load() File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2442, in load self.require(*args, **kwargs) File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2465, in require items = working_set.resolve(reqs, env, installer, extras=self.extras) File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve raise DistributionNotFound(req, requirers) pkg_resources.DistributionNotFound: The "ddt>=1.1.1" distribution was not found and is required by GitPython in conda environment. Original commit 74a0507 which added ddt there unfortunately does not state the reason so probably was just a slip
Thanks a lot! Should I cut a release? |
If not too much trouble - it would be great! Thanks in advance! |
Done, see v3.0.2 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Otherwise, since requirements.txt is loaded into install_requires, any installation
which manages to miss installing ddt could cause setuptools to freak out.
E.g.
here is a traceback from running tests of datalad
in conda environment. Original commit 74a0507
which added ddt there unfortunately does not state the reason so probably was
just a slip