Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettify support for all file types (especially (s)css) #2900

Merged
merged 4 commits into from Aug 13, 2020

Conversation

KutnerUri
Copy link
Contributor

@KutnerUri KutnerUri commented Jul 27, 2020

Proposed Changes

  • auto-deduce parser for prettier (we can add overrides later on if we run into parse errors)
  • add scss to auto prettier list
  • did not prettify existing files (I don't want to get conflicts)

@KutnerUri
Copy link
Contributor Author

KutnerUri commented Jul 27, 2020

PS. script prettier:check seems broken, it's

prettier --list-different "{ts,js,css,tsx}/**/*.{ts,js,css,tsx}"

shouldn't it be like this?

prettier --list-different \"{src,e2e}/**/*.{ts,js,css,tsx}\"

@KutnerUri KutnerUri requested a review from davidfirst Jul 27, 2020
@KutnerUri KutnerUri self-assigned this Jul 27, 2020
@davidfirst
Copy link
Member

davidfirst commented Jul 27, 2020

@KutnerUri , looks good.
Regarding prettier --list-different, you're right. It's currently incorrect. (probably no one ever used it).

@KutnerUri
Copy link
Contributor Author

KutnerUri commented Jul 28, 2020

Gilad wanted me to prettify existing css files before merging. I will make sure with Ran and Oded, prettify and merge

@KutnerUri
Copy link
Contributor Author

KutnerUri commented Aug 11, 2020

  • merge from master
  • prettified all existing css
  • regenerated package lock

@GiladShoham - ok to merge (hoping tests will pass)

@GiladShoham GiladShoham merged commit e4ebc22 into master Aug 13, 2020
12 of 16 checks passed
@GiladShoham GiladShoham deleted the ui/prettify-css branch Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants