Svgo icons cleanup #4285
Merged
Svgo icons cleanup #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use 'preset-default' as base config - use 'sortAttrs' to beautify SVG - use 'removeDimensions' to make SVG responsive
jackmcdade
approved these changes
Sep 19, 2021
|
This was on my todo list forever. Thank you! |
|
I had no idea but that's great then, one more checked box ! 💪🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi,
I've noticed Statamic SVG icons aren't all responsive because some have a hard coded
withandheight.In the exemple below, you can see that the second icon (the "earth") doesn't scale as expected:
This PR add SVGO in the project to fix this issue and optimise all SVG icons at the same time.