Skip to content

Create CODEOWNERS#1029

Merged
snappy316 merged 1 commit intomainfrom
dk/create-codeowners
Oct 12, 2022
Merged

Create CODEOWNERS#1029
snappy316 merged 1 commit intomainfrom
dk/create-codeowners

Conversation

@snappy316
Copy link
Member

The selected code owners in this PR are either because of their team or individual contributions to the codebase, a recent PR, or because more specific code owners were not identified.

Here are some possible paths forward.

  • approve the PR :)
  • accept that this is a "first effort", approve the PR, and we can iterate as pain is felt and more specific code owners are identified.
  • archive (or delete) the repo.

Any major concerns can be discussed in #codeowner-questions-comments-concerns-upheavals

We would prefer any dicussion to happen in the slack channel rather than here, because the opener of this PR is not necessarily the one who made the selection.

@snappy316 snappy316 requested a review from a team October 12, 2022 19:54
@snappy316
Copy link
Member Author

Affected Product
Which product does this bug affect?

GitHub

Describe the bug

This repo does not have a CODEOWNERS file.

To Reproduce

  1. Go to https://github.com/planningcenter/developers/tree/main/.github/CODEOWNERS
  2. Observe the 404 page

Expected behavior

Go to https://github.com/planningcenter/developers/tree/main/.github/CODEOWNERS and see

* @planningcenter/engineering-leads

Screenshots

CleanShot 2022-10-12 at 13 04 23@2x

Additional Context:

Additional context

I have..

  • Reviewed the documentation found at https://developer.planning.center/docs
  • Searched for previous issues reporting this bug
  • Removed all private information from this issue (credentials, tokens, emails, phone numbers, etc.)
  • Reviewed my issue for completeness

@snappy316 snappy316 merged commit bd7091b into main Oct 12, 2022
@seven1m seven1m deleted the dk/create-codeowners branch October 12, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants