ReDoS: testing a parameterised ReDoS module#10604
Closed
erik-krogh wants to merge 35 commits intogithub:mainfrom
Closed
ReDoS: testing a parameterised ReDoS module#10604erik-krogh wants to merge 35 commits intogithub:mainfrom
erik-krogh wants to merge 35 commits intogithub:mainfrom
Conversation
![github-advanced-security[bot]](https://waybackassets.bk21.net/20260329171025im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 63 potential problems in the proposed changes. Check the Files changed tab for more details.
erik-krogh
force-pushed
the
redosMod
branch
2 times, most recently
from
2477c9b to
8dc3908
Compare
java/ql/lib/semmle/code/java/security/regexp/ExponentialBackTracking.qll
Fixed
Show fixed
Hide fixed
java/ql/lib/semmle/code/java/security/regexp/ExponentialBackTracking.qll
Fixed
Show fixed
Hide fixed
erik-krogh
force-pushed
the
redosMod
branch
6 times, most recently
from
7d5f4e7 to
577b203
Compare
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
This was referenced Nov 1, 2022
…cations being used slightly differently in the shared pack)
…cations being used slightly differently in the shared pack)
…cations being used slightly differently in the shared pack)
Contributor
Author
|
Closing, this was just a test PR, the parts have been merged now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Depends on Create a shared implementation for Locations and Files #10592Depends on QL: prevent some cross-talk between modules #11049RegExpAnchorfrom signature?Rename the TreeView file (toNo, but collapse them.Impl?)I've only added the required classes/members/predicates to the signatures.
I'm quite sure that all the current regex parsers implement a superset of the features required in the signature.
There is a lot of duplicated member predicates in the implementations that just forward to the super class.
That's because I cannot
extenda class that comes from a signature.