Swift: Add some summary queries.#10903
Conversation
jketema
left a comment
There was a problem hiding this comment.
Mostly LGTM. Just one description I do not fully understand.
|
In addition to your suggested change I've restricted the count of "Expressions" to ones with locations in code now. It turns out there's quite a lot of locationless stuff that was exaggerating the size of smaller projects (and in turn making me wonder why we weren't finding many results, taint sources etc in them). |
atorralba
left a comment
There was a problem hiding this comment.
This LGTM. I guess summary queries don't need a docs review.
As far as I can tell summary queries don't usually get full |
No, let's keep it consistent with the rest of summary queries. Looks good as it is. |
I wrote these queries to assess the progress we're making identifying flow sources and sensitive expressions in real world Swift snapshots. I intend to track these things fairly often in the near-mid future, so it would be convenient to have the queries in the public repo. I don't think there's any harm in letting curious users see them as well.
It might be nice to have
LinesOfCode.qlandLinesOfUserCode.qlsummary queries as well as all (?) other languages do, but I don't think we extract the data for them yet.