Use octokit type directly#662
Merged
styfle merged 3 commits intostyfle:mainfrom Oct 4, 2022
foolmoron:github-type
Merged
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @styfle on Vercel. @styfle first needs to authorize it. |
styfle
reviewed
Oct 4, 2022
Co-authored-by: Steven <steven@ceriously.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
styfle
reviewed
Oct 4, 2022
| dependencies: | ||
| "@octokit/openapi-types" "^13.11.0" | ||
|
|
||
| "@octokit/types@^6.0.3", "@octokit/types@^6.16.1": |
Owner
There was a problem hiding this comment.
Kinda strange the types were already here. I bet theres a way to import the type from the existing package
styfle
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also found you can use the type directly here to make things much more maintainable and avoid a bunch of
anysTesting
yarn buildpassed type-checking