Merged
Conversation
added 3 commits
September 20, 2022 18:18
…mmandline-plumbing-infrastructure
ArinGhazarian
commented
Sep 21, 2022
| { | ||
| var commandArgsType = commandType.BaseType.GetGenericArguments()[0]; | ||
| var commandArgs = ctx.BindArgs(command, commandArgsType); | ||
| var handler = commandType.GetMethod("BuildHandler").Invoke(command, new[] { commandArgs, serviceProvider }); |
Contributor
Author
There was a problem hiding this comment.
Wouldn't it be better to check if handler implements ICommandHander and throw a meaningful exception? It is going to throw a NullReferenceException if GetMethod returns null in case it cannot find BuildHandler method anyways.
dylan-smith
reviewed
Sep 23, 2022
Co-authored-by: Dylan Smith <dylan-smith@github.com>
dylan-smith
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #639
This is all the required infrastructure changes in form of some extension method to do the plumbing for the new CommandLine. Here is a sample branch that applies these changes to
bbs2gh.I went ahead and simplified it even more by creating an extension to add all commands to the
rootCommand. Here is how it's supposed to be used: