Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for content addressing #950

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Copy link

@thrownness thrownness commented May 24, 2020

I think this is correct, but let me know!

But the key thing is that this needs to be tested on webkit browsers. Webkit powers all browsers on iOS (and Safari desktop), so it's a huge market.

@sirpy
Copy link

@sirpy sirpy commented May 24, 2020

@thrownness
you can see that travis build is failing
TypeError: Cannot read property 'get' of undefined
at SEA.work.name (/home/travis/build/amark/gun/test/sea/sea.js:44:13)
at Object.SEA.work.SEA.work (/home/travis/build/amark/gun/sea.js:278:22)
1) Content Addressing

var gun is undefined by default, you need to instantiate it. see other tests.

@thrownness
Copy link
Author

@thrownness thrownness commented May 25, 2020

I'm now seeing Warning: reusing same fs store and options as 1st., but it appears that the test works nonetheless. It throws and then there's a checkmark in front of the test.

@thrownness
Copy link
Author

@thrownness thrownness commented May 25, 2020

Are any of these tests able to be run in the browser? Or are these only for Node?

@sirpy
Copy link

@sirpy sirpy commented May 25, 2020

@thrownness
Copy link
Author

@thrownness thrownness commented May 26, 2020

https://mochajs.org/#running-mocha-in-the-browser

There might already be an html file with this setup. It just needs to be run on Safari too

@amark
Copy link

@amark amark commented Jun 3, 2020

yaaay!

tests/mocha.html I check in browser before publishing, but be nice to automate across all browsers.

ut-oh, test is failing! I'll need to look into that? I haven't peeked at the code/test yet.

👏 for more tests tho! This is how progress happens, painfully detailed, but it is laying concrete foundation & building up layer by layer at a time until the world is changed forever because they take the bedrock to be granted. Making sure our stuff actually works at each step. :)

@amark
Copy link

@amark amark commented Jun 15, 2020

@thrownness this is the thing that is breaking iOS/webkit/safari right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants