Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplnotify 0.3.4 is incompatible with procps-ng 3.3.12 #339
Comments
|
@kevr I think this is your plugin. What is the |
|
I wonder if we should: (a) just remove it:
Or (b) make it user configurable? I'm not clear what the intent is here (e.g., as currently written, this code will suppress notifications whenever I'm using an |
I have the same issue fwiw @larsks |
The python "lnotify" plugin had some problematic code that would suppress notifications if the active window was named "tilda", "xterm", or "gnome-terminal". This list was not user-configurable, and the code implementing this feature was broken due to weechat#339 (incompatible with common versions of ps) and weechat#334 (python3 bytes-vs-string incompatibility). This commit removes the problematic code. Closes: weechat#334 Closes: weechat#339
The
lnotifyscript usespsto determine the name of the currently running window, but it uses command line arguments that are not supported by the version ofpsin many distributions. The generate command line looks like:And fails like this:
Note this is a different failure than the one reported in #334.