New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix windows 3.8 dll loading for cuda #5259
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
5662861
to
9d8c201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warnings are actually not shown by default on any platform, since the CUDA devices not found or CUDA libraries not found warning will always show up when loading CUDA Open3D package on a CPU only machine.
http://www.open3d.org/docs/latest/getting_started.in.html?highlight=warnings#troubleshooting
They should show up only with python -Wdefault "import open3d". If this is not the desired behavior, we can enable them all the time with warning filter settings.
https://docs.python.org/3/library/warnings.html#default-warning-filter
warnings.filterwarnings('default', message='.*', category=ImportWarning,module='open3d')
(or more fine grained control is possible with lineno)
|
Main change: Add winmode=0 for CDLL function |
c651bf5
to
b7158e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Win 10 with Python 3.8.
warningstologgingpackage, as the warnings package does not print on Windows by default.This change is