[TS/JS] Add rollup and config to generate iife flatbuffers bundle #7449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornharrtell
changed the title
|
Looks like the TS failed because rollup wasn't found. |
|
Fixed in build script. Apparently it was not installing the deps from package.json. The only reason it worked without that must be that it used preinstalled tsc in the container which is no good anyway because we don't know which version it is. |
|
Good to go? What does this actually produce as an output? You might want to put that in the description. |
|
@dbaileychess I believe it is good to go but yes perhaps some documentation is in order and we should ensure it is included in the npm package (which on publishing will then make it available at unpkg CDN). |
|
@dbaileychess I've now detailed what this produces in the PR description. |
dbaileychess
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
ref #7426
This addition and script allows to generate a
flatbuffers.jsat root level which is a bundled up single file version of the flatbuffers implementation with the same API as what was available in flatbuffers 1.x (i.e equivalent to https://unpkg.com/flatbuffers@1.12.0/js/flatbuffers.js).