Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): move Vue example to Vite #801

Merged
merged 8 commits into from Oct 27, 2021
Merged

docs(examples): move Vue example to Vite #801

merged 8 commits into from Oct 27, 2021

Conversation

sarahdayan
Copy link
Member

@sarahdayan sarahdayan commented Oct 26, 2021

This moves the Vue example from Parcel to Vite, which should make it work in CodeSandbox.

Edit: doesn't look like CodeSandbox wants to build our examples again 😞 Also failing when importing this URL to CodeSandbox (command runs fine but getting Cannot GET/) although when starting a new terminal in the same sandbox and running yarn dev, it works 🤷🏻‍♀️ Will try Vue CLI if I don't get feedback from CodeSandbox. it works now thanks to @danilowoz

Preview link

fixes #799

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 26, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sarahdayan sarahdayan marked this pull request as draft Oct 27, 2021
@sarahdayan sarahdayan marked this pull request as ready for review Oct 27, 2021
@sarahdayan sarahdayan merged commit e04f302 into next Oct 27, 2021
9 checks passed
@sarahdayan sarahdayan deleted the docs/vue branch Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants