Runtime: evaluate Antlers within code fieldtype when antlers: true is set#5966
Merged
jackmcdade merged 4 commits intostatamic:3.3from May 2, 2022
JohnathonKoster:runtime-arrayable-string-fieldtypes-antlers-true
Merged
Runtime: evaluate Antlers within code fieldtype when antlers: true is set#5966jackmcdade merged 4 commits intostatamic:3.3from JohnathonKoster:runtime-arrayable-string-fieldtypes-antlers-true
code fieldtype when antlers: true is set#5966jackmcdade merged 4 commits intostatamic:3.3from
JohnathonKoster:runtime-arrayable-string-fieldtypes-antlers-true
Conversation
Apply fixes from StyleCI
jasonvarga
requested changes
May 2, 2022
Member
jasonvarga
left a comment
jasonvarga
left a comment
There was a problem hiding this comment.
This is only done when the site is set to runtime
I think it's pretty safe to assume if it's an ArrayableString and you have antlers enabled, it should treat it as a string. Let's remove the runtime check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #5963 by casting instances of
ArrayableStringto strings when resolving a value for Antlers when the field is configured withantlers: true. This is only done when the site is set toruntimeto prevent accidentally breaking something else.To reproduce the original issue create a code field and set
antlers: trueon the field and include some Antlers code in the value. The code will not be evaluated before this PR, but will afterwards (the included test will also fail when moved to the main branch as another way to validate).