Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[react-www] remove forked bundle" #25837

Merged
merged 1 commit into from Dec 7, 2022

Conversation

rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Dec 7, 2022

Reverts #25831

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 7, 2022
@rickhanlonii
Copy link
Member Author

rickhanlonii commented Dec 7, 2022

Merging to unblock.

@rickhanlonii rickhanlonii merged commit d4bc16a into main Dec 7, 2022
1 of 3 checks passed
@sizebot
Copy link

sizebot commented Dec 7, 2022

Comparing: d69b2cf...9b1f5cc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.33 kB 154.33 kB = 48.96 kB 48.96 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.26 kB 156.26 kB = 49.61 kB 49.61 kB
facebook-www/ReactDOM-prod.classic.js = 532.87 kB 532.87 kB = 94.93 kB 94.93 kB
facebook-www/ReactDOM-prod.modern.js = 517.97 kB 517.97 kB = 92.73 kB 92.73 kB
facebook-www/ReactDOMForked-prod.classic.js +∞% 0.00 kB 532.87 kB +∞% 0.00 kB 94.93 kB
facebook-www/ReactDOMForked-dev.classic.js +∞% 0.00 kB 1,354.49 kB +∞% 0.00 kB 294.13 kB
facebook-www/ReactDOMForked-dev.modern.js +∞% 0.00 kB 1,329.49 kB +∞% 0.00 kB 289.50 kB
facebook-www/ReactDOMForked-prod.modern.js +∞% 0.00 kB 517.97 kB +∞% 0.00 kB 92.73 kB
facebook-www/ReactDOMForked-profiling.classic.js +∞% 0.00 kB 563.26 kB +∞% 0.00 kB 99.46 kB
facebook-www/ReactDOMForked-profiling.modern.js +∞% 0.00 kB 548.26 kB +∞% 0.00 kB 97.21 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMForked-dev.classic.js +∞% 0.00 kB 1,354.49 kB +∞% 0.00 kB 294.13 kB
facebook-www/ReactDOMForked-dev.modern.js +∞% 0.00 kB 1,329.49 kB +∞% 0.00 kB 289.50 kB
facebook-www/ReactDOMForked-prod.classic.js +∞% 0.00 kB 532.87 kB +∞% 0.00 kB 94.93 kB
facebook-www/ReactDOMForked-prod.modern.js +∞% 0.00 kB 517.97 kB +∞% 0.00 kB 92.73 kB
facebook-www/ReactDOMForked-profiling.classic.js +∞% 0.00 kB 563.26 kB +∞% 0.00 kB 99.46 kB
facebook-www/ReactDOMForked-profiling.modern.js +∞% 0.00 kB 548.26 kB +∞% 0.00 kB 97.21 kB

Generated by 🚫 dangerJS against 9b1f5cc

github-actions bot pushed a commit that referenced this pull request Dec 7, 2022
Reverts #25831

DiffTrain build for `d4bc16a7d69eb2ea38a88c8ac0b461d5f72cdcab`
@kassens kassens deleted the revert-25831-remove-forked-bundle branch Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants