fix: android sdk 33 compatibility#489
Merged
Naturalclar merged 1 commit intoreact-native-menu:masterfrom Dec 15, 2022
Merged
Conversation
|
Thanks for the fix. When can we expect a new release with the fix? |
Member
|
@focux sorry for the late response, a new package with this fix has been released as v0.7.3 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Android build would crash after upgrading to sdk 33 as indicated in issue 488 . These changes get rid of the errors and it builds correctly now.
Test Plan
Tried building with sdk 31 (which is what would work before the changes) and it still passes the build.