migrating node.js APM configuration #16219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
Qard
reviewed
Dec 15, 2022
| Whether to enable the tracer. | ||
| : **Configuration**: N/A<br> | ||
| **Default**: `true`<br> | ||
| Whether to enable dd-trace. Setting this to `false` will disable all features of the library. |
There was a problem hiding this comment.
We should probably have a discussion about if it's confusing to document both DD_TRACE_ENABLED and DD_TRACING_ENABLED. Can we make a different env var for the global disable to make the distinction clearer and deprecate this one?
There was a problem hiding this comment.
I agree. I think an explanation of "this is different from DD_TRACE_ENABLED, which does X, whereas this does Y" would be a first step.
tlhunter
commented
Dec 15, 2022
kayayarai
requested changes
Dec 15, 2022
tlhunter
force-pushed
the
tlhunter/migrate-nodejs-config
branch
from
eaa8df3
to
1f4c332
Compare
tlhunter
force-pushed
the
tlhunter/migrate-nodejs-config
branch
from
1f4c332
to
7ee135b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What does this PR do?
Motivation
Preview
https://docs-staging.datadoghq.com/tlhunter/migrate-nodejs-config/tracing/trace_collection/library_config/nodejs
Additional Notes
Reviewer checklist