Add fetchPriority to <img> and <link>
#25927
Merged
+94
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. always read correct property (to test compat with lowercase prop name) 1. use a known string value to test read/write parity Ran fixture with meta tags enabled in Chrome Version 107.0.5304.110 (Official Build) (64-bit) on Ubuntu 22.04
eps1lon
approved these changes
Dec 23, 2022
|
@styfle Could you check if the value in the attribute fixture match your expectation? |
styfle
commented
Dec 23, 2022
| @@ -573,6 +573,24 @@ const attributes = [ | |||
| tagName: 'path', | |||
| read: getSVGAttribute('externalResourcesRequired'), | |||
| }, | |||
| { | |||
| name: 'fetchPriority', | |||
| overrideStringValue: 'high', | |||
There was a problem hiding this comment.
@eps1lon Why would this override? I'm not sure I understand the purpose of overrideStringValue
There was a problem hiding this comment.
Just so that we test with a valid value instead of an arbitrary one that you'd never use in a real application
github-actions bot
pushed a commit
that referenced
this pull request
Dec 23, 2022
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary - Fixes #25682 ## How did you test this change? I tried this but it didn't work ``` yarn build --type=UMD_DEV react/index,react-dom && cd fixtures/attribute-behavior && yarn install && yarn start ``` Co-authored-by: eps1lon <silbermann.sebastian@gmail.com> DiffTrain build for [de7d1c9](de7d1c9) [View git log for this commit](https://github.com/facebook/react/commits/de7d1c90718ea8f4844a2219991f7115ef2bd2c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
<img fetchPriority>attribute is not supported #25682How did you test this change?
I tried this but it didn't work