fix: make sure the initialization to throw an exception when there is no match url#718
Open
hottomato-c wants to merge 1 commit intoUniswap:mainfrom
Open
fix: make sure the initialization to throw an exception when there is no match url#718hottomato-c wants to merge 1 commit intoUniswap:mainfrom
hottomato-c wants to merge 1 commit intoUniswap:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor checking added to network initialization.
Context
Found this when launching Uniswap interface locally and chose the Evmos chain.

The original error I got is :
So I looked into it a bit and seems we have a assumption that
urlswill not be empty which in fact it could be.and 🤔 I reckon there is something we could do about it like :
Plz let me know if this makes sense to you :D
Changes
urlsnull check.