[test] Add E2E website tests #30128
Merged
[test] Add E2E website tests #30128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
force-pushed
the
docs/e2e-website
branch
from
8e60cba
to
c74bba8
Compare
oliviertassinari
reviewed
Dec 9, 2021
siriwatknp
force-pushed
the
docs/e2e-website
branch
from
5bcec79
to
4a6cfce
Compare
siriwatknp
force-pushed
the
docs/e2e-website
branch
from
4a6cfce
to
bf49a59
Compare
siriwatknp
force-pushed
the
docs/e2e-website
branch
from
cc9e251
to
84461f8
Compare
github-actions
bot
added
the
PR: out-of-date
…docs/e2e-website
github-actions
bot
removed
the
PR: out-of-date
1 task
github-actions
bot
added
the
PR: out-of-date
mnajdova
approved these changes
Dec 14, 2021
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
reviewed
Dec 14, 2021
| console.info(`url:`, payload.deploy_ssl_url); | ||
|
|
||
| // for more details > https://circleci.com/docs/2.0/api-developers-guide/# | ||
| await fetch(`https://circleci.com/api/v2/project/gh/${repo[1]}/pipeline`, { |
There was a problem hiding this comment.
A side though, the alternative option would be to:
- Run
yarn docs:buildin CircleCI - Use something to serve in the CirleCI build the .html and .js files in
/docs/.next - Run the e2e test against it
Pros:
- In the same CircleCI workflow
Potential advantage:
- If we have better CircleCI machines, then
yarn docs:buildwould build faster, but if we upgrade Netlify to a performance build, or migrate to Vercel with better build time, then that could be the opposite
Cons:
- We build the docs twice (once in Netlify, and once in CircleCI)
There was a problem hiding this comment.
I think if we can do this, that'd be great:
- build the docs
- run the e2e-test
- deploy to netlify
all of these steps are in CircleCI
oliviertassinari
added
core
oliviertassinari
changed the title
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Motivation
Summary
test/e2e-website(mostly test that all thehrefhave correct URL)deploy-succeeded.jshook to trigger the e2e-website pipeline via CircleCI API (This will test against the deploy preview URL)