[DF] Simplify friend trees creation in RLoopManager by vepadulano · Pull Request #12262 · root-project/root

vepadulano · 2023-02-08T20:59:14Z

No description provided.

phsft-bot · 2023-02-08T20:59:21Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-02-08T21:37:00Z

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-3.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-02-08T21:46:54Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-02-08T22:21:52Z

Build failed on mac12/noimt.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-02-08T22:40:45Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-02-08T22:57:48Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

projectroot.tree.dataframe.test.gtest_tree_dataframe_test_dataframe_datasetspec

phsft-bot · 2023-02-08T23:08:30Z

Build failed on mac11/cxx14.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2023-02-09T10:26:07Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

eguiraud

Thank you Vincenzo! Some doubts about the third commit to resolve :D

phsft-bot · 2023-02-09T17:09:01Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-02-14T20:00:05Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

eguiraud

LGTM! Thanks!

Whether it is done via `Internal::TreeUtils::GetFriendInfo` or an `RFriendInfo::AddFriend` overload, the `fNEntriesPerTreePerFriend` data member will have the same cardinality as the `fFriendFileNames` data member. This makes the status of the created struct more easily usable, for example it simplifies the logic in `MakeFriends`.

phsft-bot · 2023-02-15T10:57:49Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-02-15T10:59:11Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-02-15T12:19:32Z

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.tree.tree.test.gtest_tree_tree_test_friendinfo

phsft-bot · 2023-02-15T12:44:11Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.tree.tree.test.gtest_tree_tree_test_friendinfo

phsft-bot · 2023-02-15T13:04:37Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-02-15T15:57:11Z

Build failed on mac12/noimt.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roofit.hs3.test.gtest_roofit_hs3_test_testHS3HistFactory

vepadulano self-assigned this Feb 8, 2023

vepadulano requested a review from eguiraud as a code owner February 8, 2023 20:59

vepadulano force-pushed the rdf-use-makefriends branch from a82b6d6 to 7473b98 Compare February 9, 2023 10:26

vepadulano requested a review from pcanal as a code owner February 9, 2023 10:26

eguiraud added a commit to eguiraud/root that referenced this pull request Feb 9, 2023

[WIP] Wait for root-project#12262

19e551d

eguiraud added a commit to eguiraud/root that referenced this pull request Feb 9, 2023

[WIP] Wait for root-project#12262

a0d7532

vepadulano mentioned this pull request Feb 9, 2023

[tree] Propagate TTreeIndex info through GetFriendInfo/MakeFriends #12269

Merged

eguiraud suggested changes Feb 9, 2023

View reviewed changes

Comment thread tree/dataframe/src/RLoopManager.cxx Outdated

Comment thread tree/tree/src/RFriendInfo.cxx Outdated

Comment thread tree/tree/src/InternalTreeUtils.cxx Outdated

Comment thread tree/tree/src/InternalTreeUtils.cxx Outdated

vepadulano force-pushed the rdf-use-makefriends branch from 7473b98 to 0361e18 Compare February 9, 2023 17:08

vepadulano requested a review from bellenot as a code owner February 9, 2023 17:08

vepadulano force-pushed the rdf-use-makefriends branch from 0361e18 to 08325ae Compare February 14, 2023 19:59

eguiraud approved these changes Feb 15, 2023

View reviewed changes

Comment thread tree/tree/src/RFriendInfo.cxx Outdated

Comment thread tree/tree/test/friendinfo.cxx

Comment thread tree/tree/test/friendinfo.cxx Outdated

vepadulano force-pushed the rdf-use-makefriends branch from 08325ae to d06fd72 Compare February 15, 2023 10:57

vepadulano force-pushed the rdf-use-makefriends branch from d06fd72 to cc215de Compare February 15, 2023 10:59

[tree][NFC] Add tests for GetFriendInfo and MakeFriends

2c9f0dc

[DF] Simplify friend trees creation in RLoopManager

ed35531

vepadulano force-pushed the rdf-use-makefriends branch from cc215de to ed35531 Compare February 15, 2023 13:04

vepadulano merged commit f2598e9 into root-project:master Feb 15, 2023

Conversation

vepadulano commented Feb 8, 2023

Uh oh!

phsft-bot commented Feb 8, 2023

Uh oh!

phsft-bot commented Feb 8, 2023

Failing tests:

Uh oh!

phsft-bot commented Feb 8, 2023

Failing tests:

Uh oh!

phsft-bot commented Feb 8, 2023

Failing tests:

Uh oh!

phsft-bot commented Feb 8, 2023

Failing tests:

Uh oh!

phsft-bot commented Feb 8, 2023

Failing tests:

Uh oh!

phsft-bot commented Feb 8, 2023

Failing tests:

Uh oh!

phsft-bot commented Feb 9, 2023

Uh oh!

eguiraud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phsft-bot commented Feb 9, 2023

Uh oh!

phsft-bot commented Feb 14, 2023

Uh oh!

eguiraud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phsft-bot commented Feb 15, 2023

Uh oh!

phsft-bot commented Feb 15, 2023

Uh oh!

phsft-bot commented Feb 15, 2023

Failing tests:

Uh oh!

phsft-bot commented Feb 15, 2023

Failing tests:

Uh oh!

phsft-bot commented Feb 15, 2023

Uh oh!

phsft-bot commented Feb 15, 2023

Failing tests:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants