Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMade WCharacter.h more clear #26
Conversation
a == 0 ? false : true is same as a != 0 Also added extern C
It's obvious that
a == 0 ? false : true
is same asa != 0
Also a != 0 looks more clear as a Return Type to a bool function.
It's more easier to understand what it does in this form.
WCharacter.h was full of functions which utilised
a == 0 ? false : true
instead of the more easy to reada != 0
which strikes a fine balance between simplicity and readability.If we are to look at Standard Library Definitions of the various functions used like isdigit,
isalpha
etc. we find they return 0 when they do not find anything thus makingisdigit(ch) != 0
even more clearerAdded extern C
Given the fact that we are using C Functions and code that is compatible with the C Standard, I added extern C. Extern C is also used in similar C Standard Compatible Arduino header files