Deprecated ioutil & os.CreateTemp#5
Conversation
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Thanks, but apart from a light deprecated method cleanup, this change does not substantially improve the project, and only breaks it in certain scenarios.
| @@ -1,5 +1,5 @@ | |||
| module github.com/cli/browser | |||
|
|
|||
| go 1.13 | |||
There was a problem hiding this comment.
Hi, prior to this change, this library was compatible will all Go versions since Go 1.13. Your change does a cleanup of now-deprecated functionality, but adds no features nor fixes. As a result, all that your change does is makes this library incompatible with all Go versions older than the latest version. This is a backwards-incompatible change and I'd rather not accept it.
Furthermore, this fork is supposed to be a drop-in replacement for https://github.com/pkg/browser, which supports Go 1.14 and later. We want to have the same support.
|
Thanks for your review |
2 participants
As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.
TempFile is deprecated : As of Go 1.17, this function simply calls os.CreateTemp.