Skip to content

[ISSUE #6039]Optimize log level to debug from info in remoting module#6038

Closed
ni-ze wants to merge 3 commits intoapache:developfrom
ni-ze:develop
Closed

[ISSUE #6039]Optimize log level to debug from info in remoting module#6038
ni-ze wants to merge 3 commits intoapache:developfrom
ni-ze:develop

Conversation

@ni-ze
Copy link
Copy Markdown
Contributor

@ni-ze ni-ze commented Feb 13, 2023

Make sure set the target branch to develop

What is the purpose of the change

close #6039

Optimize log level to debug from info in remoting module

print large log into user log when the client shutdown.
image

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ni-ze ni-ze changed the title Optimize log level to debug from info in remoting module [ISSUE #6039]Optimize log level to debug from info in remoting module Feb 13, 2023
mxsm
mxsm previously approved these changes Feb 13, 2023
@francisoliverlee
Copy link
Copy Markdown
Member

这个也可以一起优化
image

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #6038 (d7da600) into develop (0f878b5) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##             develop    #6038      +/-   ##
=============================================
- Coverage      43.22%   43.20%   -0.03%     
+ Complexity      8846     8842       -4     
=============================================
  Files           1094     1094              
  Lines          77137    77137              
  Branches       10057    10057              
=============================================
- Hits           33346    33328      -18     
- Misses         39628    39644      +16     
- Partials        4163     4165       +2     
Impacted Files Coverage Δ
...pache/rocketmq/remoting/common/RemotingHelper.java 15.38% <50.00%> (ø)
...ache/rocketmq/broker/client/ConsumerGroupInfo.java 69.29% <0.00%> (-3.51%) ⬇️
...pl/consumer/ConsumeMessageConcurrentlyService.java 46.60% <0.00%> (-2.27%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 59.91% <0.00%> (-1.33%) ⬇️
...cketmq/broker/processor/PopBufferMergeService.java 33.33% <0.00%> (-0.71%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 48.00% <0.00%> (-0.60%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 33.97% <0.00%> (-0.56%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.17% <0.00%> (-0.47%) ⬇️
...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java 63.25% <0.00%> (-0.33%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 64.93% <0.00%> (-0.31%) ⬇️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ni-ze ni-ze deleted the branch apache:develop March 3, 2023 08:11
@ni-ze ni-ze closed this Mar 3, 2023
@ni-ze ni-ze deleted the develop branch March 3, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize log level to debug from info in remoting module

6 participants