-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crond log level environment variable #1805
Conversation
Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>
Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>
|
I'd rather change the default than introducing a new config. If someone needs customisation the script or command can always be overwritten. |
|
Is this a review? I can't check out profile, if you are a maintainer. Also, this would introduce a breaking change. I don't know how the policies for Nextcloud regarding breaking changes are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather change the default than introducing a new config. If someone needs customisation the script or command can always be overwritten.
|
@MarcelCoding Yes, @J0WI is a maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather change the default than introducing a new config. If someone needs customisation the script or command can always be overwritten.
I don't have a strong opinion either way. I lean towards changing the default outright too, for simplicity sake and because AFAIK the current verbose level was completely arbitrary (#220).
|
I've updated the loglevel to 8 (the default for BusyBox crond) https://linux.die.net/man/1/busybox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this looks simple enough - 8 seems to be also the default for busybox crond.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>
Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>
* Update docker-cron.sh Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com> * Update stack.yml Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com> * Update docker-cron.sh * Update docker-cron.sh Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com> * Update stack.yml Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com> --------- Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>
* Update docker-cron.sh Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com> * Update stack.yml Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com> * Update docker-cron.sh * Update docker-cron.sh Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com> * Update stack.yml Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com> --------- Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>
I couldn't find any documentation regarding the second cron entry point, I just found it in the stack.yaml.
I added an environment variable to configure the log level, the default case is logging every minute about 3 lines and I found that quite much - not everyone can configure it how he wants it. The default is
0just as before.Signed-off-by: Marcel 34819524+MarcelCoding@users.noreply.github.com