Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crond log level environment variable #1805

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Add crond log level environment variable #1805

merged 5 commits into from
Nov 14, 2023

Conversation

MarcelCoding
Copy link
Contributor

I couldn't find any documentation regarding the second cron entry point, I just found it in the stack.yaml.
I added an environment variable to configure the log level, the default case is logging every minute about 3 lines and I found that quite much - not everyone can configure it how he wants it. The default is 0 just as before.

Signed-off-by: Marcel 34819524+MarcelCoding@users.noreply.github.com

Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>
Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>
@J0WI
Copy link
Contributor

J0WI commented Mar 28, 2023

I'd rather change the default than introducing a new config. If someone needs customisation the script or command can always be overwritten.

@MarcelCoding
Copy link
Contributor Author

MarcelCoding commented Mar 28, 2023

Is this a review? I can't check out profile, if you are a maintainer.

Also, this would introduce a breaking change. I don't know how the policies for Nextcloud regarding breaking changes are.

Copy link
Contributor

@J0WI J0WI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather change the default than introducing a new config. If someone needs customisation the script or command can always be overwritten.

@joshtrichards
Copy link
Member

@MarcelCoding Yes, @J0WI is a maintainer.

Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather change the default than introducing a new config. If someone needs customisation the script or command can always be overwritten.

I don't have a strong opinion either way. I lean towards changing the default outright too, for simplicity sake and because AFAIK the current verbose level was completely arbitrary (#220).

@MarcelCoding
Copy link
Contributor Author

I've updated the loglevel to 8 (the default for BusyBox crond) https://linux.die.net/man/1/busybox

Copy link

@arge-oevv arge-oevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks simple enough - 8 seems to be also the default for busybox crond.

Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

docker-cron.sh Outdated Show resolved Hide resolved
Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>
Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>
@J0WI J0WI merged commit 3cbec37 into nextcloud:master Nov 14, 2023
9 of 21 checks passed
@MarcelCoding MarcelCoding deleted the patch-1 branch November 15, 2023 10:32
pathob pushed a commit to pathob/nextcloud-docker that referenced this pull request Jan 14, 2024
* Update docker-cron.sh

Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>

* Update stack.yml

Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>

* Update docker-cron.sh

* Update docker-cron.sh

Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>

* Update stack.yml

Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>

---------

Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>
ananace pushed a commit to ananace/docker-nextcloud that referenced this pull request May 10, 2024
* Update docker-cron.sh

Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>

* Update stack.yml

Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>

* Update docker-cron.sh

* Update docker-cron.sh

Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>

* Update stack.yml

Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>

---------

Signed-off-by: Marcel <34819524+MarcelCoding@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cron.php logging hardcoded to highest verbosity - Reduce or add ability to change at runtime
4 participants