Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disabled widgets to material and cupertino demos #722

Merged
merged 6 commits into from Jun 29, 2022
Merged

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Jun 27, 2022

Improve the demos by showcasing disabled widgets.

This also fixes an issue with the toggleable widgets' states, and the header which appears when a data table item is selected.

@guidezpl guidezpl requested a review from goderbauer June 27, 2022 19:50
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do we need tests for this change?

lib/demos/cupertino/cupertino_slider_demo.dart Outdated Show resolved Hide resolved
@guidezpl
Copy link
Member Author

Will just update existing tests.

@guidezpl guidezpl merged commit b2becbb into main Jun 29, 2022
11 checks passed
@guidezpl guidezpl deleted the disabled-widgets branch June 29, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants