Skip to content

/ jsonapi

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of encoding integers to strings #121

Open
wants to merge 2 commits into
base: master
from
Open

Initial implementation of encoding integers to strings #121

wants to merge 2 commits into from

Conversation

@mylanconnolly
Copy link

@mylanconnolly mylanconnolly commented Nov 8, 2017

This is in reference to #120.

I added some code to enable marshalling and unmarshalling the following types to/from strings:

  • int
  • int64
  • *int
  • *int64

To accomplish this, you would use a struct tag of string, like the built-in json encoding package. For example:

type Example struct {
  // ...
  ParentID int64 `jsonapi:"attr,parent-id,string"`
  // ...
}

I have added tests to verify my new functionality is working as expected and all existing tests still pass, so I don't think I messed with the default behavior by doing this.

Thanks!
@mylanconnolly
Initial implementation of encoding integers to strings
Loading status checks…
9d5af7f
@googlebot
Copy link

@googlebot googlebot commented Nov 8, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.
@mylanconnolly
Copy link
Author

@mylanconnolly mylanconnolly commented Nov 8, 2017

Signed CLA per the comment.
@googlebot
Copy link

@googlebot googlebot commented Nov 8, 2017

CLAs look good, thanks!
@mylanconnolly mylanconnolly mentioned this pull request Nov 8, 2017
Open
@shwoodard
Copy link
Contributor

@shwoodard shwoodard commented Nov 9, 2017

Looks good so far, please add tests for error cases, e.g. not an int on parse. @mylanconnolly
@mylanconnolly
Added test case for invalid strings
Loading status checks…
e5020f0
@mylanconnolly
Copy link
Author

@mylanconnolly mylanconnolly commented Nov 9, 2017

Added a test case to include strings that cannot be parsed to numbers.

Please let me know if you'd like to see more test cases. I don't believe my changes affected any more logic than that.
@shwoodard
Copy link
Contributor

@shwoodard shwoodard commented Nov 10, 2017

Please add support for doubles/floats too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@mylanconnolly @googlebot @shwoodard
You can’t perform that action at this time.