Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage report #2894

Merged
merged 3 commits into from Nov 6, 2021
Merged

Add code coverage report #2894

merged 3 commits into from Nov 6, 2021

Conversation

prateek3255
Copy link
Contributor

Fixes #2834

@vercel
Copy link

vercel bot commented Nov 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/CbsJQbR4q1GyBuhapcALmxtzYHd5
Preview: https://react-query-git-fork-prateek3255-feat-add-code-db56b8-tanstack.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 20d2282:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

No coverage uploaded for pull request base (master@f348673). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2894   +/-   ##
=========================================
  Coverage          ?   93.49%           
=========================================
  Files             ?       44           
  Lines             ?     2184           
  Branches          ?      627           
=========================================
  Hits              ?     2042           
  Misses            ?      139           
  Partials          ?        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f348673...20d2282. Read the comment docs.

@prateek3255
Copy link
Contributor Author

@TkDodo You would need to set up codecov for this repo and install this app bot comments for the status checks to work.

Also, I have set the target coverage to 90% with a 1% threshold, but there are a variety of recommended recipes that you can choose from from here

@TkDodo
Copy link
Collaborator

TkDodo commented Nov 6, 2021

@prateek3255 thanks a lot - I can see that the bot has posted already without installing the app 🤔

#2894 (comment)

@prateek3255
Copy link
Contributor Author

@prateek3255 thanks a lot - I can see that the bot has posted already without installing the app 🤔

#2894 (comment)

Yeah, I am not really sure how it worked without installing 😅. Could it be possible that the app was already installed?

@TkDodo
Copy link
Collaborator

TkDodo commented Nov 6, 2021

Yeah, I am not really sure how it worked without installing 😅. Could it be possible that the app was already installed?

possibly. I'll ask @tannerlinsley . Anyways, this is great, thank you 🙏

@TkDodo TkDodo merged commit bfef84c into TanStack:master Nov 6, 2021
8 checks passed
@prateek3255 prateek3255 deleted the feat/add-code-coverage branch November 6, 2021 14:59
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup code-coverage
3 participants