Skip to content

add module goleft/indexsplit#2989

Merged
matthdsm merged 6 commits intomasterfrom
module/goleft_indexsplit
Mar 8, 2023
Merged

add module goleft/indexsplit#2989
matthdsm merged 6 commits intomasterfrom
module/goleft_indexsplit

Conversation

@matthdsm
Copy link
Contributor

@matthdsm matthdsm commented Mar 8, 2023

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it!

matthdsm and others added 3 commits March 8, 2023 11:47
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
@matthdsm matthdsm added this pull request to the merge queue Mar 8, 2023
@matthdsm
Copy link
Contributor Author

matthdsm commented Mar 8, 2023

Thanks @nvnieuwk and @FriederikeHanssen

Merged via the queue into master with commit a689351 Mar 8, 2023
@matthdsm matthdsm deleted the module/goleft_indexsplit branch March 8, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants