Add an efficient text stream write function #14821
Open
+496
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Product-Conhost
|
me reading this pr body rn
|
lhecker
force-pushed
the
dev/lhecker/8000-stream-writing
branch
from
db90593
to
1a24ff3
Compare
This comment has been minimized.
This comment has been minimized.
lhecker
force-pushed
the
dev/lhecker/8000-stream-writing
branch
from
1a24ff3
to
a6c5e7a
Compare
j4james
reviewed
Mar 7, 2023
DHowett
reviewed
Mar 7, 2023
This comment has been minimized.
This comment has been minimized.
lhecker
commented
Mar 9, 2023
| uint16_t column = 0; | ||
| for (const auto& ch : std::wstring_view{ L"AB\u304bC\u304dDE " }) | ||
| { | ||
| const uint16_t width = ch >= 0x80 ? 2 : 1; | ||
| pRow->ReplaceCharacters(column, width, { &ch, 1 }); | ||
| column += width; | ||
| } |
There was a problem hiding this comment.
I forgot why I made this change... But it's much shorter now, so there's that at least.
| @@ -65,6 +68,65 @@ constexpr OutIt copy_n_small(InIt first, Diff count, OutIt dest) | |||
| return dest; | |||
| } | |||
|
|
|||
| RowTextIterator::RowTextIterator(std::span<const wchar_t> chars, std::span<const uint16_t> charOffsets, uint16_t offset) noexcept : | |||
There was a problem hiding this comment.
RowTextIterator isn't used anywhere yet, but I did use it during development as a debug aid. I expect this struct to be used in the future for things like CHAR_INFO reads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This adds PR adds a couple foundational functions and classes to make
our TextBuffer more performant and allow us to improve our Unicode
correctness in the future, by getting rid of our dependence on
OutputCellIterator. In the future we can then replace the simpleUTF-16 code point iterator with a proper grapheme cluster iterator.
While my focus is technically on Unicode correctness, the ~4x VT
throughput increase in OpenConsole is pretty nice too.
This PR adds:
NavigateToPrevious,NavigateToNext)They're based on functions that align the cursor to the start/end
of the current cell, so such functions can be added as well.
Writeto write a raw string of text with the possibility tospecify a right margin.
WriteWithOffsetswill allow us to make reflow much faster,as it's able to bulk-copy already measured strings extremely fast
without re-measuring them.
Related to #8000
Validation Steps Performed
wide glyph reflow at the end of a row