fix(paste): replace selected blocks on pasting by kaaaaaaaaaaai · Pull Request #1996 · codex-team/editor.js

kaaaaaaaaaaai · 2022-03-11T05:39:19Z

Resolves #1705

I always use products. And I was stressed about this issue, so I tried a fix. And I'm here to discuss solutions.

Maybe a caret issue...? and it did not work without _deley

If you think you can figure out the cause, please let me know and I will fix it.

Tasks

Writing Tests

     _.delay(() => {
        document.execCommand(
          'insertHTML',
          false,
          clean(content.innerHTML, currentToolSanitizeConfig)
        );
      }, 20)();

…codex-team#1705)

hiepxanh · 2022-04-08T05:36:26Z

hello, anybody here?

robonetphy · 2022-04-21T03:34:21Z

@kaaaaaaaaaaai, Thanks for creating the PR for the issue and sorry for the late response.
Can you pls update the test case according to your pr so we can go for merge.
I guess you just need to increase this time.

src/components/modules/ui.ts

src/components/modules/paste.ts

neSpecc · 2022-05-01T12:57:41Z

src/components/modules/caret.ts

    BlockManager.setCurrentBlockByChildNode(block.holder);
    BlockManager.currentBlock.currentInput = element;
+
+    return new Promise<void>((resolve) => {


why do we need the delay and the Promise?

this moment still looks like a not ideal solution. Please, describe the problem you are solving

kaaaaaaaaaaai · 2022-05-09T12:00:11Z

@robonetphy @neSpecc
thank you response.

i try! I'll do my best to contribute!

docs/CHANGELOG.md

neSpecc · 2022-05-21T18:48:34Z

src/components/modules/caret.ts

    BlockManager.setCurrentBlockByChildNode(block.holder);
    BlockManager.currentBlock.currentInput = element;
+
+    return new Promise<void>((resolve) => {


this moment still looks like a not ideal solution. Please, describe the problem you are solving

neSpecc · 2022-05-21T18:50:03Z

src/components/modules/paste.ts

   */
  private setCallback(): void {
-    this.listeners.on(this.Editor.UI.nodes.holder, 'paste', this.handlePasteEvent);
+    this.listeners.on(document, 'paste', this.handlePasteEvent);


Have you tested pasting on a page that has several editor instances? You can test on the example-multiple.html page

Yup it's not working but then we need to think about it

robonetphy · 2022-05-23T10:06:45Z

@neSpecc about the promise we added into the caret.ts, if you check here
Currently, there is a delay during the caret set process since we are trying to replace the entire or partial content of the editor we need to do the following steps:

Remove all the selected blocks.
add a new empty default block.
set the caret to it (need a promise to wait for the caret to set).
add all the clipboard contents

kaaaaaaaaaaai · 2022-05-25T15:25:14Z

That's right! That's what I wanted to say :)))))

neSpecc · 2023-02-18T02:21:38Z

src/components/modules/paste.ts

+    if (!BlockSelection.anyBlockSelected) {
+      return;


seems like the previous behavior is disabled at all.

neSpecc · 2023-02-18T02:22:43Z

src/components/modules/paste.ts

+      /**
+       * process multi-block selection paste.
+       */
+      dataTransfer = await this.processMultiBlockSelection(dataTransfer);


anyBlockSelected does not guarantee that there are several blocks. There could be the single block selected.

neSpecc · 2023-02-18T02:23:47Z

src/components/modules/paste.ts

+    const { BlockManager, Caret } = this.Editor;
+
+    /** Remove all the selected blocks */
+    const nextBlockIndex = BlockManager.removeSelectedBlocks();


i think it should be somewhere inside processDataTransfer

neSpecc · 2023-02-18T02:25:57Z

src/components/modules/paste.ts

+    /** Create copy of the clipboard since new default block insertion change the event.*/
+    const clipboard = _.copyClipboard(dataTransfer);


it is not clear. how adding a new block affects data in a clipboard?

neSpecc · 2023-02-18T02:27:15Z

Lack of tests

fix: can't relplace text when paste command with multi selected blocks(…

15db3da

…codex-team#1705)

kaaaaaaaaaaai requested review from gohabereg, khaydarov and neSpecc as code owners March 11, 2022 05:39

Merge branch 'next' into fix/codex-team#1705

d4b40bd

robonetphy self-assigned this Apr 13, 2022

neSpecc added the not ready label Apr 26, 2022

robonetphy added 4 commits April 28, 2022 23:18

Merge branch 'next' into fix/codex-team#1705

451c368

feat: cart return promise

9eb2684

copy of data transfer object added

fcfee5a

feat:clipboard copy utils added

44fc6c1

robonetphy changed the title ~~fix: can't relplace text when paste command with multi selected blocks(#1705)~~ fix: can't replace text when paste command with multi selected blocks(#1705) Apr 28, 2022

changelog added

65829ac

robonetphy removed request for gohabereg, khaydarov and neSpecc April 28, 2022 18:49

timeout increase 21

81e1e9d

robonetphy requested review from gohabereg and neSpecc April 28, 2022 19:25

Merge branch 'next' into fix/codex-team#1705

d9a9f62

robonetphy requested review from TatianaFomina and ilyamore88 as code owners May 1, 2022 12:34

robonetphy removed the not ready label May 1, 2022

neSpecc requested changes May 1, 2022

View reviewed changes

robonetphy added 3 commits May 12, 2022 22:06

Merge branch 'next' into fix/codex-team#1705

6f94210

test case time delay and paste event removed

78ccba9

remove ui changes

c42cfd7

robonetphy added 5 commits May 12, 2022 22:46

multi block paste operation added

cf32827

changelog updated

8945532

replace unwanted changes

9ce3bd4

next version added in changelog

9ee535e

package version updated

e1c1d34

ilyamore88 approved these changes May 12, 2022

View reviewed changes

docs/CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

44c2377

neSpecc reviewed May 21, 2022

View reviewed changes

robonetphy added 4 commits May 27, 2022 20:21

multiple editor support added

75f6434

lint removed

134247b

Merge branch 'next' into fix/codex-team#1705

bc2984c

docs added

7b0172d

neSpecc requested changes Feb 18, 2023

View reviewed changes

neSpecc added not ready nice to have labels Feb 18, 2023

neSpecc changed the title ~~fix: can't replace text when paste command with multi selected blocks(#1705)~~ fix(paste): replace selected blocks on pasting Feb 18, 2023

		/** Create copy of the clipboard since new default block insertion change the event.*/
		const clipboard = _.copyClipboard(dataTransfer);

Uh oh!

Conversation

kaaaaaaaaaaai commented Mar 11, 2022 • edited by neSpecc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hiepxanh commented Apr 8, 2022

Uh oh!

robonetphy commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kaaaaaaaaaaai commented May 9, 2022

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robonetphy May 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robonetphy commented May 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaaaaaaaaaaai commented May 25, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

neSpecc commented Feb 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kaaaaaaaaaaai commented Mar 11, 2022 •

edited by neSpecc

Loading

robonetphy commented Apr 21, 2022 •

edited

Loading

robonetphy May 23, 2022 •

edited

Loading

robonetphy commented May 23, 2022 •

edited

Loading