Skip to content

Give delete key a chance#2284

Closed
gkovats wants to merge 2 commits intocodex-team:nextfrom
gkovats:feature/deletekey
Closed

Give delete key a chance#2284
gkovats wants to merge 2 commits intocodex-team:nextfrom
gkovats:feature/deletekey

Conversation

@gkovats
Copy link

@gkovats gkovats commented Feb 21, 2023

Not a TS dev naturally, this is definitely a copy / paste from the backspace() method. Basically just adding "delete" key behavior to base editor, a variant of backspace.

  • when multiple blocks are selected, it's the same behavior
  • when on a blank line, same behavior
  • when at the end of a block and the next block is of same type and supports merge, merge the next block to current

Our environment is very Windows heavy, and delete key is more prominent in Win UIs, so this was missing from the experience. Perhaps the blockEvents delete() logic is a little repetitive now, but this helps bridge the gap for folks expecting standard line navigation / merging. Tossing up for what it's worth.

@gorenburg
Copy link
Contributor

Yes, bumped into the same feature request from users. Give it a chance, @codex-team!

@neSpecc
Copy link
Member

neSpecc commented Jul 6, 2023

Resolved by #2402

@neSpecc neSpecc closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants