Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom tooltips with native ones and add description to all e… #37244

Merged
merged 1 commit into from Mar 16, 2023
Merged

Replace custom tooltips with native ones and add description to all e… #37244

merged 1 commit into from Mar 16, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Mar 15, 2023 •
edited by come-nc

Replace custom tooltips with native ones and add description to all elements which have title.

Summary

Make tooltips in LDAP wizard readable and accessible.

Before:

image

After:

Screenshot from 2023-03-15 18-26-55

Checklist

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Mar 15, 2023
@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable25

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable26

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Mar 15, 2023
artonge
artonge approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain shortly why is a title and a description needed ?

@JuliaKirschenheuter
Copy link
Contributor Author

Can you explain shortly why is a title and a description needed ?

Of coarse. Well title was already there and was implemented as hints for user. But they are working only for users with a mouse. Additionally I've added a description for screen reader users. Actually such hint have to be accessible for keyboard users too (now it is not). But that would need much more UI changes as we have it how.

https://www.24a11y.com/2017/the-trials-and-tribulations-of-the-title-attribute/

We don't have LDAP integration (app) in out test instance and because of this i would leave it like this for now ;)

@ChristophWurst ChristophWurst removed their request for review March 16, 2023 10:46
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 16, 2023
blizzz
blizzz requested changes Mar 16, 2023
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one remark

apps/user_ldap/js/wizard/view.js Outdated Show resolved Hide resolved
@JuliaKirschenheuter
Replace custom tooltips with native ones and add description to all e…
b698cb2 
…lements which have `title`

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/37179-replace-custom-tooltips-with-native-ones branch from 603b7eb to b698cb2 Compare March 16, 2023 11:11
@blizzz blizzz added this to the Nextcloud 27 milestone Mar 16, 2023
@JuliaKirschenheuter JuliaKirschenheuter merged commit 1001769 into master Mar 16, 2023
37 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/37179-replace-custom-tooltips-with-native-ones branch March 16, 2023 14:16
This was referenced Mar 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@come-nc come-nc come-nc approved these changes

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
📐 Accessibility
Status: ☑️ Done
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.

[BITV]: Tooltips in LDAP wizard unreadable
6 participants
@JuliaKirschenheuter @blizzz @artonge @Pytal @come-nc @ChristophWurst