Rework add_grub_bootloader()

[codefiles]

• This fixes issue: Enabling Zram support should disable Zswap #1493 (Disable zswap #881)

PR Description:

• Rework add_grub_bootloader()
• Replace sed approach with Pythonic style
• Disable zswap if zram is enabled

Tests and Checks

• I have tested the code!

[Dungeonseeker]

Couldn't you simply echo the parameter into "/etc/sysctld.d/99-zram.conf"? That way it would work regardless of what bootloader the user is running.

For clarification - https://man.archlinux.org/man/sysctl.d.5

[codefiles]

That is certainly a valid option and one I had not considered. I was simply replicating the solution that was merged for systemd-boot.

If the pull requests that I have open for boot loaders are merged I plan to then submit a pull request to move any of the code that is duplicated in the boot loader functions to the add_bootloader() function. This would include moving the kernel parameters from the boot loader functions to add_bootloader() and adding them as a parameter to the boot loader functions. The idea would be to do the check if zram is enabled in add_bootloader() and if it is add the paramater to the kernel parameter list. Then when the appropriate boot loader function is called the kernel parameter list will be passed to it as an argument.

[Torxed]

Looks good and the future plans are a nice direction. Just needs the latest rework-grub fix and conflicts sorted and I'll merge in!

[codefiles]

I plan to close this once the kernel parameters are taking care of in a separate pull request since most of this was superseded by:

• Refactor _add_grub_bootloader() configuration #1962
• Refactor _add_grub_bootloader() installation #1968

[codefiles]

In addition to the list given in the last comment, also superseded by:

• Rework _get_kernel_params() for _add_grub_bootloader() #2079