Skip to content

Comments

Added modernize-use-emplace, modernize-loop-convert clang-tidy check#5610

Merged
larshg merged 1 commit intoPointCloudLibrary:masterfrom
gnawme:feature/add-modernize-use-emplace
Feb 21, 2023
Merged

Added modernize-use-emplace, modernize-loop-convert clang-tidy check#5610
larshg merged 1 commit intoPointCloudLibrary:masterfrom
gnawme:feature/add-modernize-use-emplace

Conversation

@gnawme
Copy link
Contributor

@gnawme gnawme commented Feb 15, 2023

Added the modernize-use-emplace and modernize-loop-convert checks for clang-tidy

Fixed some odd misspellings


Fixed formatting escapes


Ran 'build format' to resolve clang-format issues


Debugging odd compile error


Fixed more issues from CI


Addressed CI issues and review feedback


Added missing const

Added yet more missing const


Reverted another omp parallel for


Reverted for third-party code


Disabled clang-tidy for third-party code
@gnawme gnawme force-pushed the feature/add-modernize-use-emplace branch from ee15ec0 to de0381d Compare February 20, 2023 23:53
Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@larshg larshg merged commit b551ee4 into PointCloudLibrary:master Feb 21, 2023
@larshg larshg added this to the pcl-1.13.1 milestone Feb 21, 2023
@gnawme gnawme deleted the feature/add-modernize-use-emplace branch February 21, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants