catches media that are appended to the dom as a child#80
Open
steveseguin wants to merge 10 commits intorse:masterfrom
Open
catches media that are appended to the dom as a child#80steveseguin wants to merge 10 commits intorse:masterfrom
steveseguin wants to merge 10 commits intorse:masterfrom
Conversation
Catches scenarios like this I think:
body.appendChild.createElementFromHTML("
<div>
<video />
</div>
")
fix for vdo.ninja v22
Owner
|
I've taken over the fix for the issue when media added as a child of a parent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The system already handles existing media and media directly added to dom, but not media that's a child of another element that is actually being added. this patch should fix that I think