C++: Move SsaConsistency to its own file #12583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
commented
Mar 20, 2023
Comment on lines
-541
to
548
| /** | ||
| * Gets a string that uniquely identifies an `IROpaqueType` tag. This may be different from the usual | ||
| * `toString()` of the tag in order to ensure uniqueness. | ||
| * Gets a string that uniquely identifies an `IROpaqueType` tag. Using `toString` here might | ||
| * not be sufficient to ensure uniqueness, but suffices for our current debugging purposes. | ||
| * To ensure uniqueness `getOpaqueTagIdentityString` from `semmle.code.cpp.Print` could be used, | ||
| * but that comes at the cost of importing all the `Dump` classes defined in that library. | ||
| */ | ||
| string getOpaqueTagIdentityString(Type tag) { | ||
| hasOpaqueType(tag, _) and | ||
| result = getTypeIdentityString(tag) | ||
| result = tag.toString() | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is probably somewhat dubious. However, this still seems to suffice for our tests (which is the only place where this is used). I tried to factor this out and keep the old definition. Unfortunately this means factoring out all getUniqueId and related predicates, which if non-trivial.
jketema
force-pushed
the
move-print
branch
3 times, most recently
from
70a3bb0 to
9031348
Compare
jketema
commented
Mar 20, 2023
Comment on lines
-1119
to
-1120
| /** DEPRECATED: Alias for SsaConsistency */ | ||
| deprecated module SSAConsistency = SsaConsistency; |
Contributor
Author
There was a problem hiding this comment.
Moving this to SSAConsistency.qll resulted in the following warning:
WARNING: Reference to SSAConsistency references a local library, not the named module.
So I dropped this instead. Note that this was deprecated early September 2022.
This removes the import of the `Print` library in places that are used in production and not just debugging.
MathiasVP
approved these changes
Mar 20, 2023
Contributor
MathiasVP
left a comment
MathiasVP
left a comment
There was a problem hiding this comment.
LGTM once DCA/CI is happy!
Contributor
Author
|
DCA looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the import of the
Printlibrary in places that are used in production and not just debugging.I've only added a change note for C++, as the C# changes live in an experimental directory.