Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release-schedule.yml formatting that fails on the CI #3294

Merged
merged 2 commits into from May 17, 2023
Merged

Update release-schedule.yml formatting that fails on the CI #3294

merged 2 commits into from May 17, 2023

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented May 17, 2023 •
edited

Formatting fails on the release-schedule.yml and this PR updates it

CI logs: https://github.com/primer/react/actions/runs/4997763524/jobs/8952463962

Screenshots

No visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@broccolinisoup broccolinisoup requested a review from a team as a code owner May 17, 2023 00:22
@changeset-bot
Copy link

changeset-bot bot commented May 17, 2023 •
edited

⚠️ No Changeset found

Latest commit: 360e74b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@broccolinisoup broccolinisoup changed the title Update jest snapshots for Pagination changes that is missing https://github.com/primer/react/pull/3277 Update jest snapshots for Pagination changes that is missing #3277 May 17, 2023
@broccolinisoup broccolinisoup changed the title Update jest snapshots for Pagination changes that is missing #3277 Update jest snapshots for Pagination changes that is missing on #3277 May 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023 •
edited

size-limit report 📦

Path Size
dist/browser.esm.js 115.96 KB (0%)
dist/browser.umd.js 117.79 KB (0%)

@broccolinisoup broccolinisoup mentioned this pull request May 17, 2023
Merged
6 tasks
@github-actions github-actions bot temporarily deployed to storybook-preview-3294 May 17, 2023 00:29 Inactive
@broccolinisoup broccolinisoup changed the title Update jest snapshots for Pagination changes that is missing on #3277 Update release-schedule.yml formatting that fails on the CI May 17, 2023
@github-actions github-actions bot temporarily deployed to storybook-preview-3294 May 17, 2023 00:37 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages May 17, 2023 00:44 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3294 May 17, 2023 00:44 Inactive
@broccolinisoup broccolinisoup added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit 434f542 May 17, 2023
29 checks passed
@broccolinisoup broccolinisoup deleted the update-snapshots-pagination branch May 17, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

Assignees
No one assigned
Labels
skip changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@broccolinisoup @colebemis