JakeWharton
Follow
Pinned
4,011 contributions in the last year
Activity overview
Contribution activity
May 2023
Created 162 commits in 21 repositories
Created a pull request in cashapp/redwood that received 4 comments
Create Redwood build plugin
It's like convention plugins, but better because it's an actual API that can be stateful.
+364
−187
•
4
comments
Opened 82 other pull requests in 8 repositories
cashapp/redwood
55
merged
1
closed
- Send a real frame time for Treehouse frame clocks
- Send a real frame time for Redwood frame clocks
- Remove obsolete experimental suppression
- Group ktlint and Spotless in Renovate
- Do not spend more than 5m trying to download caches on CI
- Add native frame clock for iOS and MacOS
-
Move
HostConfigurationcomposition local into Redwood - Rename 'redwood-compose-testing' to 'redwood-testing'
-
Rename
ViewTreetoSnapshotChangeList - Add two additional testing strategies to the view tree generation
- Move Dokka to its own job
-
Add
Modifiersupport toViewTreegeneration -
Use a schema's
ProtocolBridgeto record changes from aWidgetValue -
Move
HostConfigurationinto Redwood - Do not nest protocol modules in test schema
-
Simplify generation of
equals/hashCode/toString/childrenListsinWidgetValues - Retain a single protocol-based children wrapper
-
ViewTreenodes should be created top-down but added bottom-up - Supply the children index from the parent when assembling a view tree
- Allow tester functions to return values
- Make value class constructors and properties fully private
-
Carry
HostConfigurationStateFlowall the way to Compose -
Move
Dp,Density, andMarginto runtime - Add schema parser serialization detection test
- Add documentation to the schema and codegen
- Some pull requests not shown.
JakeWharton/mosaic
6
merged
willowtreeapps/assertk
6
merged
square/kotlinpoet
5
merged
cashapp/molecule
4
merged
cashapp/zipline
3
merged
JakeWharton/platform-collections
1
merged
cashapp/turbine
1
merged
Reviewed 155 pull requests in 12 repositories
cashapp/redwood
25 pull requests
- Update plugin com.gradle.enterprise to v3.13.3
- Update dependency com.android.tools.lint:lint to v31.0.2
- Update dependency com.android.tools.build:gradle to v8.0.2
- Group ktlint and Spotless in Renovate
- Remove unused Paging Runtime dependency
- Update androidx-activity to v1.7.2
- Update dependency com.diffplug.spotless:spotless-plugin-gradle to v6.19.0
- Fix LazyList skipping items
- Remove pagination dependency in Redwood Lazy Layout guest code
- Update dependency com.google.testparameterinjector:test-parameter-injector to v1.12
-
Add
Modifiersupport toViewTreegeneration -
Use a schema's
ProtocolBridgeto record changes from aWidgetValue - Rename LayoutModifier to Modifier
-
ViewTreenodes should be created top-down but added bottom-up - Update coil to v2.4.0
- Update dependency com.willowtreeapps.assertk:assertk to v0.26.1
- Move ItemPagingSource to LazyList and attribute LazyListIntervalContent to Android
- Limit window size of LazyList items instead of growing as one scrolls
- Update dependency org.robolectric:robolectric to v4.10.3
- Add ‘pull to refresh’ and indicator support to LazyLists
- Introduce LazyLayoutIntervalContent for generic interval-based content
- Use IntervalList data structure to efficiently handle LazyList intervals
- Parse event lambdas and children scopes in FIR
- Simplify internal LazyList#items block
- Support multiple arguments in event lambdas
- Some pull request reviews not shown.
cashapp/zipline
25 pull requests
- Flatten host and guest platform interfaces
- Move serviceNamesArray to be a regular bridged call
- Move EventListener to engineMain
- Rename engineMain to hostMain
- Fix zipline-profiler README.
- Update dependency androidx.activity:activity-compose to v1.7.2
- Update http4k to v4.44.1.0
- Update plugin spotless to v6.19.0
- Update auto-service to v1.1.0
- Update dependency org.xerial:sqlite-jdbc to v3.42.0.0
- Update dependency io.coil-kt:coil-compose to v2.4.0
- Use internal visibility in internal packages
- Update dependency com.willowtreeapps.assertk:assertk to v0.26.1
- Track our latest @OptIn usage
- Run wycheproof tests on iOS platforms
- Promote ZiplineManifest to the main zipline module
- Update dependency org.xerial:sqlite-jdbc to v3.41.2.2
- Prettify some string literals
- Update http4k to v4.44.0.0
- Update http4k to v4.43.1.0
- Update dependency com.vanniktech:gradle-maven-publish-plugin to v0.25.2
- Update kotlinx-coroutines to v1.7.1
- Update kotlinx-coroutines to v1.7.0
- Update dependency androidx.core:core-ktx to v1.10.1
- Update dependency app.cash.turbine:turbine to v0.13.0
- Some pull request reviews not shown.
cashapp/sqldelight
25 pull requests
- Update plugin com.gradle.enterprise to v3.13.3
- Update dependency com.pinterest:ktlint to v0.49.1
- Update agp to v8.0.2
- Refresh pip-compile outputs
- Update plugin spotless to v6.19.0
- Fix automatic version text in docs
- Update dependency com.google.testparameterinjector:test-parameter-injector to v1.12
- Add integration test using Kotlin 1.9.0-Beta
- Update dependency com.squareup:kotlinpoet to v1.13.2
- Update dependency org.xerial:sqlite-jdbc to v3.42.0.0
- Refresh pip-compile outputs
- Update dependency org.xerial:sqlite-jdbc to v3.41.2.2
- Update dependency org.robolectric:robolectric to v4.10.3
- Update dependency com.squareup.moshi:moshi to v1.15.0
- Update com.squareup.moshi to v1.15.0
- Update kotlinCoroutines to v1.7.1
- Update dependency app.cash.turbine:turbine to v0.13.0
- Update dependency app.cash.turbine:turbine to v0.12.3
- Update testcontainers-java monorepo to v1.18.1
- Fix releasing removed mingwX86 artifact
- Remove deprecated targets
- Remove support for old MM
- Update kotlinCoroutines to v1.7.0
- Update dependency org.robolectric:robolectric to v4.10.2
- Update dependency org.robolectric:robolectric to v4.10.1
- Some pull request reviews not shown.
cashapp/paparazzi
19 pull requests
- Update Android Gradle Plugin and tools dependencies
- Group ksp and Kotlin updates, AGP and tools updates
- Switch from kapt to ksp for Moshi codegen
- Weaken test assertion to match to workaround transform SHA issue
- Compose 1.4.7 and Kotlin 1.8.21
- Remove redundant call to ConfigurationContainer.add, already added by ConfigurationContainer.create
- Switch to BuildConfig plugin to generate plugin version info
- Decouple Dokka from Kotlin versioning
- Use truth for BuildClass plugin tests instead of plain assert
- Avoid building code on mkdoc dependency updates
- Only reference major versions in workflow actions
- Move Gradle wrapper validator action to own workflow
- Group Compose compiler into Kotlin update PRs
- Migrate from AssertJ to Truth
- Update external library paths to be relative to gradle user home not project root directory
- Configure Environment with local and library resource paths
- Bump to AGP 7.4.2
- Simplify artifactView logic
- Introduce temporary bridge for resource loaders to ResourceResolver
square/kotlinpoet
6 pull requests
willowtreeapps/assertk
3 pull requests
square/okhttp
2 pull requests
cashapp/licensee
2 pull requests
AndroidStudyGroup/conferences
1 pull request
cashapp/contour
1 pull request
cashapp/molecule
1 pull request
cashapp/turbine
1 pull request
Created an issue in cashapp/redwood that received 2 comments
Send real time in frame clocks, and test it
Android, JS, and coming soon native. Make sure they all send real times.
2
comments
Opened 32 other issues in 8 repositories
cashapp/redwood
10
open
7
closed
- Treehouse for MacOS targets
- Bundle ktlint and Spotless in Renovate
-
Ensure we're prepared for adopting
AutoCloseablefrom stdlib -
Introduce
RedwoodView -
ViewTreetest should validate output in two ways -
ViewTreeis top-down walk whereas normal usage is bottom-up - Capture event lambda parameter names from the schema
- Allow more than one event argument
-
HostConfigurationshould be part of Redwood, not Treehouse - Counter iOS Compose UI frontend
-
Rename
LayoutModifiertoModifier - Track and validate public API
-
Eliminate
data classfrom public API - Revamp the widget-side codegen to better facilitate the protocol and testing
- Allocation reduction pass
-
ViewTreeAPI incorrect children tag logic -
ViewTreeAPI incorrect child index calculation
cashapp/zipline
4
open
1
closed
square/kotlinpoet
2
open
1
closed
cashapp/molecule
2
open
willowtreeapps/assertk
1
open
1
closed
JakeWharton/mosaic
1
closed
Kotlin/kotlinx.coroutines
1
open
cashapp/paparazzi
1
open
Answered 1 discussion in 1 repository
cashapp/molecule
cashapp/molecule
-
Is there a way to only run the molecule when its being collected?
This contribution was made on May 17
23
contributions
in private repositories
May 2 – May 25