feat: WDS algorithmic negative colors#23948
Merged
Conversation
c14ee36 to
6eb7aae
Compare
ichik
commented
Jun 6, 2023
app/client/packages/design-system/theming/src/utils/TokensAccessor/DarkModeTheme.ts
Outdated
Show resolved
Hide resolved
ichik
commented
Jun 6, 2023
app/client/packages/design-system/theming/src/utils/TokensAccessor/DarkModeTheme.ts
Outdated
Show resolved
Hide resolved
dca6888 to
aaa0d95
Compare
80f3ac6 to
9943250
Compare
9943250 to
e4c1b4a
Compare
KelvinOm
approved these changes
Jun 13, 2023
|
|
||
| get isRed() { | ||
| return this.color.oklch.h >= 29 && this.color.oklch.h <= 50; | ||
| return this.color.oklch.h >= 5 && this.color.oklch.h <= 49; |
Collaborator
There was a problem hiding this comment.
@ichik (just thoughts) Maybe we should check other ranges as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tl;dr Checking whether seed falls into the interval and picking most distant red
Fixes #22365
Media
Screen.Recording.2023-06-13.at.10.35.41.mov
Type of change
How Has This Been Tested?
Test Plan
Initial POC refinement, no testing necessary
Checklist:
Dev activity
QA activity: