Skip to content

feat: WDS algorithmic negative colors#23948

Merged
KelvinOm merged 10 commits intoreleasefrom
feat/wds-color-negative
Jun 13, 2023
Merged

feat: WDS algorithmic negative colors#23948
KelvinOm merged 10 commits intoreleasefrom
feat/wds-color-negative

Conversation

@ichik
Copy link
Contributor

@ichik ichik commented Jun 1, 2023

Description

tl;dr Checking whether seed falls into the interval and picking most distant red
Fixes #22365

Media

Screen.Recording.2023-06-13.at.10.35.41.mov

Type of change

  • New feature (non-breaking change which adds functionality)
  • Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

  • Manual

Test Plan

Initial POC refinement, no testing necessary

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@ichik ichik added skip-changelog Adding this label to a PR prevents it from being listed in the changelog skip-testPlan WDS team labels Jun 1, 2023
@ichik ichik requested review from KelvinOm, jsartisan and somangshu June 1, 2023 11:13
@ichik ichik self-assigned this Jun 1, 2023
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Anvil Pod Issue related to Anvil project Widget Styling Enhancement New feature or request and removed skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Jun 1, 2023
@ichik ichik force-pushed the feat/wds-color-negative branch from c14ee36 to 6eb7aae Compare June 1, 2023 11:51
@somangshu somangshu removed their request for review June 2, 2023 05:06
@ichik ichik force-pushed the feat/wds-color-negative branch from dca6888 to aaa0d95 Compare June 9, 2023 08:41
@ichik ichik force-pushed the feat/wds-color-negative branch from 80f3ac6 to 9943250 Compare June 12, 2023 14:15
@ichik ichik force-pushed the feat/wds-color-negative branch from 9943250 to e4c1b4a Compare June 12, 2023 14:17
@ichik ichik marked this pull request as ready for review June 13, 2023 08:38

get isRed() {
return this.color.oklch.h >= 29 && this.color.oklch.h <= 50;
return this.color.oklch.h >= 5 && this.color.oklch.h <= 49;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ichik (just thoughts) Maybe we should check other ranges as well.

@KelvinOm KelvinOm merged commit ceaba67 into release Jun 13, 2023
@KelvinOm KelvinOm deleted the feat/wds-color-negative branch June 13, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Anvil Pod Issue related to Anvil project Enhancement New feature or request WDS team Widgets Product This label groups issues related to widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: WDS negative color tokens

2 participants